Skip to content

[BOLT] Improve profile quality reporting #130810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2025
Merged

[BOLT] Improve profile quality reporting #130810

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39112ae
Report 0.00% profile quality gaps under empty eligible functions / bl…
ShatianWang Mar 11, 2025
8121b86
Fixed format; added EH stats; skipped selected blocks in CFG flow
ShatianWang Mar 19, 2025
504c78e
clang-format
ShatianWang Apr 3, 2025
707a465
Merge branch 'main' into ModifyFormat
ShatianWang Apr 3, 2025
ae84c47
fix issue with call graph flow conservation score
ShatianWang Apr 3, 2025
fae410b
clang-format
ShatianWang Apr 3, 2025
dd35926
Address comments
ShatianWang Apr 17, 2025
31ce06c
simplify
ShatianWang Apr 18, 2025
0bbd659
clang-format
ShatianWang Apr 18, 2025
2de14fb
fix is invoke check
ShatianWang Apr 22, 2025
9ccb2d7
fix division by zero
ShatianWang Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions bolt/lib/Passes/ProfileQualityStats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,16 @@ struct FlowInfo {
FunctionFlowMapTy CallGraphIncomingFlows;
};

// When reporting exception handling stats, we only consider functions with at
// least MinLPECSum counts in landing pads to avoid false positives due to
// sampling noise
const uint16_t MinLPECSum = 50;

// When reporting CFG flow conservation stats, we only consider blocks with
// execution counts > MinBlockCount when reporting the distribution of worst
// gaps.
const uint16_t MinBlockCount = 500;

template <typename T>
void printDistribution(raw_ostream &OS, std::vector<T> &values,
bool Fraction = false) {
Expand Down Expand Up @@ -245,7 +255,7 @@ void printCallGraphFlowConservationStats(
const double CallGraphGap = 1 - (double)Min / Max;

if (opts::Verbosity >= 2 && CallGraphGap >= 0.5) {
OS << "Nontrivial call graph gap of size "
OS << "Non-trivial call graph gap of size "
<< formatv("{0:P}", CallGraphGap) << " observed in function "
<< Function->getPrintName() << "\n";
if (opts::Verbosity >= 3)
Expand Down Expand Up @@ -275,9 +285,6 @@ void printCFGFlowConservationStats(const BinaryContext &BC, raw_ostream &OS,
std::vector<double> CFGGapsWeightedAvg;
std::vector<double> CFGGapsWorst;
std::vector<uint64_t> CFGGapsWorstAbs;
// We only consider blocks with execution counts > MinBlockCount when
// reporting the distribution of worst gaps.
const uint16_t MinBlockCount = 500;
for (const BinaryFunction *Function : Functions) {
if (Function->size() <= 1 || !Function->isSimple()) {
CFGGapsWeightedAvg.push_back(0.0);
Expand Down Expand Up @@ -311,14 +318,9 @@ void printCFGFlowConservationStats(const BinaryContext &BC, raw_ostream &OS,
if (BB.isLandingPad())
continue;

bool HasPosECLP = false;
for (const BinaryBasicBlock *LP : BB.landing_pads()) {
if (LP->getKnownExecutionCount() > 0) {
HasPosECLP = true;
break;
}
}
if (HasPosECLP)
auto isPosEC = std::bind(&BinaryBasicBlock::getKnownExecutionCount,
std::placeholders::_1);
if (llvm::any_of(BB.landing_pads(), isPosEC))
Copy link
Contributor

@aaupov aaupov Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maksim told me about this trick:

Suggested change
auto isPosEC = std::bind(&BinaryBasicBlock::getKnownExecutionCount,
std::placeholders::_1);
if (llvm::any_of(BB.landing_pads(), isPosEC))
if (llvm::any_of(BB.landing_pads(),
std::mem_fn(&BinaryBasicBlock::getKnownExecutionCount))

continue;

// We don't consider blocks that end with a recursive call instruction
Expand Down Expand Up @@ -354,7 +356,7 @@ void printCFGFlowConservationStats(const BinaryContext &BC, raw_ostream &OS,
if (WeightSum > 0)
WeightedGap /= WeightSum;
if (opts::Verbosity >= 2 && WorstGap >= 0.9) {
OS << "Nontrivial CFG gap observed in function "
OS << "Non-trivial CFG gap observed in function "
<< Function->getPrintName() << "\n"
<< "Weighted gap: " << formatv("{0:P}", WeightedGap) << "\n";
if (BBWorstGap)
Expand Down Expand Up @@ -420,9 +422,7 @@ void printExceptionHandlingStats(const BinaryContext &BC, raw_ostream &OS,
}
}
}
// We only consider functions with at least MinLPECSum counts in landing
// pads to avoid false positives due to sampling noise
const uint16_t MinLPECSum = 50;

if (LPECSum <= MinLPECSum) {
LPCountFractionsOfTotalBBEC.push_back(0.0);
LPCountFractionsOfTotalInvokeEC.push_back(0.0);
Expand Down
Loading