Skip to content

Conversation

@Jerry-Ge
Copy link
Member

@llvmbot
Copy link
Member

llvmbot commented Mar 11, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-tosa

Author: Jerry-Ge (Jerry-Ge)

Changes

Align description with the spec. https://www.mlplatform.org/tosa/tosa_spec.html#_matmul


Full diff: https://github.com/llvm/llvm-project/pull/130835.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td (+2-4)
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index c5667f2b6c7e9..d6b9ec3c64690 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -300,12 +300,10 @@ def Tosa_FFT2dOp : Tosa_InferShapedTypeOp<"fft2d", [
 // Operator: matmul
 //===----------------------------------------------------------------------===//
 def Tosa_MatMulOp : Tosa_InferShapedTypeOp<"matmul"> {
-  let summary = "Matrix multiplication with bias";
+  let summary = "Matrix multiplication";
 
   let description = [{
-    Performs a two dimensional matrix multiplication. This allows both inputs to
-    be activations, rather than reserving weights as an attribute in the
-    FULLY_CONNECTED operator.
+    Performs a two dimensional matrix multiplication.
   }];
 
   let arguments = (ins

Align description with the spec.

Signed-off-by: Luke Hutton <[email protected]>
Change-Id: I6ee41cb8c98cd778a90b1fabe4f3c4042cc22a17
@Jerry-Ge Jerry-Ge merged commit 89fa592 into llvm:main Mar 11, 2025
9 of 10 checks passed
@Jerry-Ge Jerry-Ge deleted the matmul branch March 20, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants