Skip to content

Conversation

@hiraditya
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 11, 2025

@llvm/pr-subscribers-llvm-ir

Author: AdityaK (hiraditya)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/130843.diff

1 Files Affected:

  • (modified) llvm/lib/IR/AutoUpgrade.cpp (+1-1)
diff --git a/llvm/lib/IR/AutoUpgrade.cpp b/llvm/lib/IR/AutoUpgrade.cpp
index cb4ecc60aa473..97cb91bb402c1 100644
--- a/llvm/lib/IR/AutoUpgrade.cpp
+++ b/llvm/lib/IR/AutoUpgrade.cpp
@@ -5044,7 +5044,7 @@ static void upgradeNVVMFnVectorAttr(const StringRef Attr, const char DimC,
   }
 
   const unsigned Dim = DimC - 'x';
-  assert(Dim >= 0 && Dim < 3 && "Unexpected dim char");
+  assert(Dim < 3 && "Unexpected dim char");
 
   const uint64_t VInt = mdconst::extract<ConstantInt>(V)->getZExtValue();
 

Copy link
Member

@AlexMaclean AlexMaclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiraditya hiraditya merged commit b17af9d into llvm:main Mar 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants