-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[CIR] Upstream basic support for sizeof and alignof #130847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
337b23e
858383e
ec780a7
2857d49
2997d72
744687f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,6 +92,8 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> { | |
|
|
||
| mlir::Value VisitCastExpr(CastExpr *E); | ||
|
|
||
| mlir::Value VisitUnaryExprOrTypeTraitExpr(const UnaryExprOrTypeTraitExpr *e); | ||
|
|
||
| /// Emit a conversion from the specified type to the specified destination | ||
| /// type, both of which are CIR scalar types. | ||
| /// TODO: do we need ScalarConversionOpts here? Should be done in another | ||
|
|
@@ -148,3 +150,27 @@ mlir::Value ScalarExprEmitter::VisitCastExpr(CastExpr *ce) { | |
| } | ||
| return {}; | ||
| } | ||
|
|
||
| /// Return the size or alignment of the type of argument of the sizeof | ||
| /// expression as an integer. | ||
| mlir::Value ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr( | ||
| const UnaryExprOrTypeTraitExpr *e) { | ||
| const QualType typeToSize = e->getTypeOfArgument(); | ||
| if (e->getKind() == UETT_SizeOf) { | ||
| if (const VariableArrayType *variableArrTy = | ||
| cgf.getContext().getAsVariableArrayType(typeToSize)) { | ||
| cgf.getCIRGenModule().errorNYI(e->getSourceRange(), | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is this recovering? Will there be a known-const-int in this case to give a valid value? Same on 169.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will check
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think instead that after each of these
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice i used 1 as recovering value for unimplemented yet cases |
||
| "sizeof operator for VariableArrayType", | ||
| e->getStmtClassName()); | ||
| } | ||
| } else if (e->getKind() == UETT_OpenMPRequiredSimdAlign) { | ||
| cgf.getCIRGenModule().errorNYI( | ||
| e->getSourceRange(), | ||
| "sizeof operator for Not yet implemented: ", e->getStmtClassName()); | ||
| } | ||
|
|
||
| return builder.create<cir::ConstantOp>( | ||
| cgf.getLoc(e->getSourceRange()), cgf.cgm.UInt64Ty, | ||
| builder.getAttr<cir::IntAttr>( | ||
| cgf.cgm.UInt64Ty, e->EvaluateKnownConstInt(cgf.getContext()))); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o - 2>&1 | filecheck %s | ||
|
|
||
| void foo() { | ||
| unsigned long b = sizeof(bool); | ||
| // CHECK: cir.const #cir.int<1> : !cir.int<u, 64> | ||
|
|
||
| unsigned long i = sizeof(int); | ||
| // CHECK: cir.const #cir.int<4> : !cir.int<u, 64> | ||
|
|
||
| unsigned long l = sizeof(long); | ||
| // CHECK: cir.const #cir.int<8> : !cir.int<u, 64> | ||
|
|
||
| unsigned long f = sizeof(float); | ||
| // CHECK: cir.const #cir.int<4> : !cir.int<u, 64> | ||
|
|
||
| unsigned long d = sizeof(double); | ||
| // CHECK: cir.const #cir.int<8> : !cir.int<u, 64> | ||
| } | ||
|
|
||
| void foo2() { | ||
| unsigned long b = alignof(bool); | ||
| // CHECK: cir.const #cir.int<1> : !cir.int<u, 64> | ||
|
|
||
| unsigned long i = alignof(int); | ||
| // CHECK: cir.const #cir.int<4> : !cir.int<u, 64> | ||
|
|
||
| unsigned long l = alignof(long); | ||
| // CHECK: cir.const #cir.int<8> : !cir.int<u, 64> | ||
|
|
||
| unsigned long f = alignof(float); | ||
| // CHECK: cir.const #cir.int<4> : !cir.int<u, 64> | ||
|
|
||
| unsigned long d = alignof(double); | ||
| // CHECK: cir.const #cir.int<8> : !cir.int<u, 64> | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -fclangir -emit-llvm %s -o - 2>&1 | FileCheck %s | ||
|
|
||
| void foo() { | ||
| unsigned long b = sizeof(bool); | ||
| // CHECK: store i64 1, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long i = sizeof(int); | ||
| // CHECK: store i64 4, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long l = sizeof(long); | ||
| // CHECK: store i64 8, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long f = sizeof(float); | ||
| // CHECK: store i64 4, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long d = sizeof(double); | ||
| // CHECK: store i64 8, ptr {{%.*}}, align 4 | ||
| } | ||
|
|
||
| void foo2() { | ||
| unsigned long b = alignof(bool); | ||
| // CHECK: store i64 1, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long i = alignof(int); | ||
| // CHECK: store i64 4, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long l = alignof(long); | ||
| // CHECK: store i64 8, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long f = alignof(float); | ||
| // CHECK: store i64 4, ptr {{%.*}}, align 4 | ||
|
|
||
| unsigned long d = alignof(double); | ||
| // CHECK: store i64 8, ptr {{%.*}}, align 4 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here:
llvm-project/clang/lib/CodeGen/CGExprScalar.cpp
Line 3471 in dc23234
This is missing A LOT of those things it needs. I think this function needs more work (even if it is just NYI).