[lldb-dap] Validate server mode support prior to invoking lldb-dap.

[ashgti]

This should ensure the extension only uses server mode if the binary supports the feature, otherwise it will fallback to the existing behavior.

Fixes #130854

[llvmbot]

@llvm/pr-subscribers-lldb

Author: John Harrison (ashgti)

Changes

This should ensure the extension only uses server mode if the binary supports the feature, otherwise it will fallback to the existing behavior.

Fixes #130854

---

Full diff: https://github.com/llvm/llvm-project/pull/130855.diff

1 Files Affected:

• (modified) lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts (+6-1)

diff --git a/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts b/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts
index 1f76fe31b00ad..c2244dcbde8f2 100644
--- a/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts
+++ b/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts
@@ -93,6 +93,11 @@ async function getDAPExecutable(
   return undefined;
 }
 
+async function isServerModeSupported(exe: string): Promise<boolean> {
+  const { stdout } = await exec(exe, ['--help']);
+  return /--connection/.test(stdout);
+}
+
 /**
  * This class defines a factory used to find the lldb-dap binary to use
  * depending on the session configuration.
@@ -145,7 +150,7 @@ export class LLDBDapDescriptorFactory
     const dbgArgs = executable?.args ?? [];
 
     const serverMode = config.get<boolean>('serverMode', false);
-    if (serverMode) {
+    if (serverMode && await isServerModeSupported(dapPath)) {
       const { host, port } = await this.startServer(dapPath, dbgArgs, dbgOptions);
       return new vscode.DebugAdapterServer(port, host);
     }