reapply [llvm] add support for mustache templating language #130876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-project into llvm-add-mustache
…m-project into llvm-add-mustache
…m-project into llvm-add-mustache
…m-project into llvm-add-mustache
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/9343 Here is the relevant piece of the build log for the reference |
Collaborator
|
New memory leaks https://lab.llvm.org/buildbot/#/builders/24/builds/6240/steps/12/logs/stdio cc @pcc |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2476 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/2486 Here is the relevant piece of the build log for the reference |
Contributor
|
@PeterChou1 |
PeterChou1
added a commit
to PeterChou1/llvm-project
that referenced
this pull request
Mar 13, 2025
…lvm#130876)" This reverts commit 6bf0c46.
ilovepi
reviewed
Mar 18, 2025
| std::string Body; | ||
| ASTNode *Parent; | ||
| // TODO: switch implementation to SmallVector<T> | ||
| std::vector<ASTNode *> Children; |
Contributor
There was a problem hiding this comment.
I think you're getting leaks reported w/ this vector because the ASTNodes are allocated via BumpPtrAllocator, and thus never have their destructors called. Things allocated via BumpPtrAllocator can't have owned heap allocations like this. The two std::strings above are also problematic for the same reason.
When this used StringRef originally, it wasn't an issue for the strings. For the vector, you probably need to either rethink the overall strategy, or pass it in via reference. Maybe DenseMap<ASTNode*, vector<ASTNode*>> is workable using the same patterns/lifetimes as the StringMaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #130732
Fixes errors which broke build bot that uses GCC as a compiler
https://lab.llvm.org/buildbot/#/builders/66/builds/11049
GCC threw an warning due to an issue std::move with a temporary object which prevents copy elision. Fixes the issue by removing the std::move
Adds Support for the Mustache Templating Language. See specs here: https://mustache.github.io/mustache.5.html
This patch implements support+tests for majority of the features of the language including:
This meant as a library to support places where we have to generate HTML, such as in clang-doc.