Skip to content

[flang][OpenMP] Don't allow namelist variables with threadprivate #130957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tblah wants to merge 2 commits into from
Closed

[flang][OpenMP] Don't allow namelist variables with threadprivate #130957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0800f12
[flang][OpenMP] Don't allow namelist variables with threadprivate
tblah Mar 12, 2025
42438c5
Restrict to only the threadprivate directive
tblah Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions flang/lib/Semantics/check-omp-structure.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,12 @@ void OmpStructureChecker::CheckThreadprivateOrDeclareTargetVar(
"A variable in a %s directive cannot appear in an "
"EQUIVALENCE statement"_err_en_US,
ContextDirectiveAsFortran());
} else if (name->symbol->test(Symbol::Flag::InNamelist) &&
GetContext().directive ==
llvm::omp::Directive::OMPD_threadprivate) {
context_.Say(name->source,
"A variable in a %s directive cannot appear in a NAMELIST"_err_en_US,
ContextDirectiveAsFortran());
} else if (name->symbol->test(Symbol::Flag::OmpThreadprivate) &&
GetContext().directive ==
llvm::omp::Directive::OMPD_declare_target) {
Expand Down Expand Up @@ -1571,6 +1577,13 @@ void OmpStructureChecker::CheckThreadprivateOrDeclareTargetVar(
ContextDirectiveAsFortran(), obj->name(),
name.symbol->name());
}
if (obj->test(Symbol::Flag::InNamelist) &&
GetContext().directive ==
llvm::omp::OMPD_threadprivate) {
context_.Say(name.source,
"A variable in a %s directive cannot appear in a NAMELIST"_err_en_US,
ContextDirectiveAsFortran());
}
}
}
}
Expand Down
12 changes: 12 additions & 0 deletions flang/test/Semantics/OpenMP/threadprivate09.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
! RUN: %python %S/../test_errors.py %s %flang_fc1 %openmp_flags

! Check that namelist variables cannot be used with threadprivate

module m
integer :: nam1
common /com1/nam1
namelist /nam/nam1

!ERROR: A variable in a THREADPRIVATE directive cannot appear in a NAMELIST
!$omp threadprivate(/com1/)
end
Loading