Skip to content

[DirectX] Change placeholders from undef to poison #130970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025
Merged

[DirectX] Change placeholders from undef to poison #130970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ static Value *expandCrossIntrinsic(CallInst *Orig) {
Value *zx_xz = MulSub(op0_z, op0_x, op1_z, op1_x);
Value *xy_yx = MulSub(op0_x, op0_y, op1_x, op1_y);

Value *cross = UndefValue::get(VT);
Value *cross = PoisonValue::get(VT);
cross = Builder.CreateInsertElement(cross, yz_zy, (uint64_t)0);
cross = Builder.CreateInsertElement(cross, zx_xz, 1);
cross = Builder.CreateInsertElement(cross, xy_yx, 2);
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Target/DirectX/DXILOpLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ class OpLowerer {
if (!Extracts[I])
Extracts[I] = IRB.CreateExtractValue(Op, I);

Value *Vec = UndefValue::get(OldTy);
Value *Vec = PoisonValue::get(OldTy);
for (int I = 0, E = N; I != E; ++I)
Vec = IRB.CreateInsertElement(Vec, Extracts[I], I);
OldResult->replaceAllUsesWith(Vec);
Expand Down
2 changes: 1 addition & 1 deletion llvm/test/CodeGen/DirectX/BufferLoad.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ define void @loadv4f32() {
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA4]], 1
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA4]], 2
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA4]], 3
; CHECK: insertelement <4 x float> undef
; CHECK: insertelement <4 x float> poison
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
Expand Down
14 changes: 7 additions & 7 deletions llvm/test/CodeGen/DirectX/RawBufferLoad.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ define void @loadv4f32_struct(i32 %index) {
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 1
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 2
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 3
; CHECK: insertelement <4 x float> undef
; CHECK: insertelement <4 x float> poison
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
Expand Down Expand Up @@ -97,7 +97,7 @@ define void @loadv4f32_byte(i32 %offset) {
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 1
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 2
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATA]], 3
; CHECK: insertelement <4 x float> undef
; CHECK: insertelement <4 x float> poison
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
Expand Down Expand Up @@ -125,7 +125,7 @@ define void @loadelements(i32 %index) {
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 1
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 2
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 3
; CHECK: insertelement <4 x float> undef
; CHECK: insertelement <4 x float> poison
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
Expand All @@ -144,7 +144,7 @@ define void @loadelements(i32 %index) {
; CHECK: extractvalue %dx.types.ResRet.i32 [[DATAI32]], 1
; CHECK: extractvalue %dx.types.ResRet.i32 [[DATAI32]], 2
; CHECK: extractvalue %dx.types.ResRet.i32 [[DATAI32]], 3
; CHECK: insertelement <4 x i32> undef
; CHECK: insertelement <4 x i32> poison
; CHECK: insertelement <4 x i32>
; CHECK: insertelement <4 x i32>
; CHECK: insertelement <4 x i32>
Expand Down Expand Up @@ -180,7 +180,7 @@ define void @loadnested(i32 %index) {
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 1
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 2
; CHECK: extractvalue %dx.types.ResRet.f32 [[DATAF32]], 3
; CHECK: insertelement <4 x float> undef
; CHECK: insertelement <4 x float> poison
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
; CHECK: insertelement <4 x float>
Expand All @@ -196,7 +196,7 @@ define void @loadnested(i32 %index) {
; CHECK: extractvalue %dx.types.ResRet.f16 [[DATAF16]], 0
; CHECK: extractvalue %dx.types.ResRet.f16 [[DATAF16]], 1
; CHECK: extractvalue %dx.types.ResRet.f16 [[DATAF16]], 2
; CHECK: insertelement <3 x half> undef
; CHECK: insertelement <3 x half> poison
; CHECK: insertelement <3 x half>
; CHECK: insertelement <3 x half>
; CHECK: call void @v3f16_user(<3 x half>
Expand All @@ -221,7 +221,7 @@ define void @loadv4f64_byte(i32 %offset) {
; CHECK: extractvalue %dx.types.ResRet.f64 [[DATA]], 1
; CHECK: extractvalue %dx.types.ResRet.f64 [[DATA]], 2
; CHECK: extractvalue %dx.types.ResRet.f64 [[DATA]], 3
; CHECK: insertelement <4 x double> undef
; CHECK: insertelement <4 x double> poison
; CHECK: insertelement <4 x double>
; CHECK: insertelement <4 x double>
; CHECK: insertelement <4 x double>
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/DirectX/cross.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ entry:
; CHECK: %4 = fmul half %x0, %y1
; CHECK: %5 = fmul half %x1, %y0
; CHECK: %hlsl.cross3 = fsub half %4, %5
; CHECK: %6 = insertelement <3 x half> undef, half %hlsl.cross1, i64 0
; CHECK: %6 = insertelement <3 x half> poison, half %hlsl.cross1, i64 0
; CHECK: %7 = insertelement <3 x half> %6, half %hlsl.cross2, i64 1
; CHECK: %8 = insertelement <3 x half> %7, half %hlsl.cross3, i64 2
; CHECK: ret <3 x half> %8
Expand All @@ -47,7 +47,7 @@ entry:
; CHECK: %4 = fmul float %x0, %y1
; CHECK: %5 = fmul float %x1, %y0
; CHECK: %hlsl.cross3 = fsub float %4, %5
; CHECK: %6 = insertelement <3 x float> undef, float %hlsl.cross1, i64 0
; CHECK: %6 = insertelement <3 x float> poison, float %hlsl.cross1, i64 0
; CHECK: %7 = insertelement <3 x float> %6, float %hlsl.cross2, i64 1
; CHECK: %8 = insertelement <3 x float> %7, float %hlsl.cross3, i64 2
; CHECK: ret <3 x float> %8
Expand Down