Skip to content

Conversation

@wrotki
Copy link
Contributor

@wrotki wrotki commented Mar 13, 2025

Silence darwin bot while we investigate the problem

rdar://145873843

@llvmbot
Copy link
Member

llvmbot commented Mar 13, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Mariusz Borsa (wrotki)

Changes

Silence darwin bot while we investigate the problem

rdar://145873843


Full diff: https://github.com/llvm/llvm-project/pull/131234.diff

1 Files Affected:

  • (modified) compiler-rt/test/sanitizer_common/TestCases/Darwin/malloc_zone.cpp (+2)
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Darwin/malloc_zone.cpp b/compiler-rt/test/sanitizer_common/TestCases/Darwin/malloc_zone.cpp
index fd6ef03629438..e68e93129be2f 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Darwin/malloc_zone.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Darwin/malloc_zone.cpp
@@ -17,6 +17,8 @@
 // UBSan does not install a malloc zone.
 // XFAIL: ubsan
 //
+// Curently fails on darwin/lsan rdar://145873843
+// XFAIL: darwin && lsan
 
 #include <malloc/malloc.h>
 #include <stdlib.h>

@wrotki wrotki requested a review from thetruestblue March 13, 2025 22:52
@wrotki wrotki merged commit ab58a3c into llvm:main Mar 13, 2025
11 of 12 checks passed
@wrotki wrotki deleted the eng/m_borsa/xfail_145873843 branch March 13, 2025 23:01
@wrotki wrotki added this to the LLVM 20.X Release milestone Mar 25, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Mar 25, 2025
@wrotki
Copy link
Contributor Author

wrotki commented Mar 25, 2025

/cherry-pick ab58a3c

@llvmbot
Copy link
Member

llvmbot commented Mar 25, 2025

/pull-request #133006

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Mar 25, 2025
@wrotki
Copy link
Contributor Author

wrotki commented Apr 1, 2025

/cherry-pick ab58a3c 02837ac

@llvmbot
Copy link
Member

llvmbot commented Apr 1, 2025

Failed to cherry-pick: 02837ac

https://github.com/llvm/llvm-project/actions/runs/14184007163

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@llvmbot
Copy link
Member

llvmbot commented Apr 1, 2025

Failed to cherry-pick: 02837ac

https://github.com/llvm/llvm-project/actions/runs/14184007163

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants