Skip to content

Conversation

@yonghong-song
Copy link
Contributor

In [1], Nikita Popov spotted that two BitCast operations are not needed with opaque pointers. So remove these two BitCast operations and adjust corresponding comments as well.

[1] #130722

In [1], Nikita Popov spotted that two BitCast operations are not needed
with opaque pointers. So remove these two BitCast operations and adjust
corresponding comments as well.

  [1] llvm#130722
@yonghong-song
Copy link
Contributor Author

cc @4ast @eddyz87

Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yonghong-song
Copy link
Contributor Author

The test failures are from BOLT (buildkite/github-pull-requests/linux-linux-x64:

BOLT
BOLT.X86/icf-safe-icp.test
BOLT.X86/icf-safe-process-rela-data.test
BOLT.X86/icf-safe-test1.test
BOLT.X86/icf-safe-test2GlobalConstPtrNoPic.test

so it is not related to this patch.

@yonghong-song yonghong-song merged commit 389ed47 into llvm:main Mar 14, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants