[libc++][test] Skip a is_virtual_base_of test for apple-clang-17
#131438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that Apple Clang 17 starts to be used for CI, while it hasn't supported `__builtin_is_virtual_base_of` yet.
frederick-vs-ja
added
libc++
Contributor
Author
Member
|
@llvm/pr-subscribers-libcxx Author: A. Jiang (frederick-vs-ja) ChangesIt seems that Apple Clang 17 starts to be used for CI, while it hasn't supported Follows up #131302. Full diff: https://github.com/llvm/llvm-project/pull/131438.diff 1 Files Affected:
diff --git a/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp b/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp
index bcffa5812d04e..f443d2030961d 100644
--- a/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp
@@ -9,7 +9,7 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, c++23
// These compilers don't support __builtin_is_virtual_base_of yet.
-// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-16
+// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-16, apple-clang-17
// <type_traits>
|
frederick-vs-ja
added a commit
to frederick-vs-ja/llvm-project
that referenced
this pull request
Mar 16, 2025
…lvm#131438) It seems that Apple Clang 17 starts to be used for CI, while it hasn't supported `__builtin_is_virtual_base_of` yet. And thus we need to skip the test for `is_virtual_base_of`. Follows up llvm#131302.
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 18, 2025
…lvm#131438) It seems that Apple Clang 17 starts to be used for CI, while it hasn't supported `__builtin_is_virtual_base_of` yet. And thus we need to skip the test for `is_virtual_base_of`. Follows up llvm#131302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Apple Clang 17 starts to be used for CI, while it hasn't supported
__builtin_is_virtual_base_ofyet. And thus we need to skip the test foris_virtual_base_of.Follows up #131302.