Skip to content

[CodeGen] Avoid repeated hash lookups (NFC) #131495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025
Merged

[CodeGen] Avoid repeated hash lookups (NFC) #131495

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9bb1d8
[CodeGen] Avoid repeated hash lookups (NFC)
kazutakahirata Mar 15, 2025
f1499ec
Address a comment.
kazutakahirata Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions llvm/lib/CodeGen/MachineDebugify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,13 @@ bool applyDebugifyMetadataToMachineFunction(MachineModuleInfo &MMI,

// Find a suitable local variable for the DBG_VALUE.
unsigned Line = MI.getDebugLoc().getLine();
if (!Line2Var.count(Line))
auto It = Line2Var.find(Line);
if (It == Line2Var.end()) {
Line = EarliestDVI ? EarliestDVI->getDebugLoc().getLine()
: EarliestDVR->getDebugLoc().getLine();
DILocalVariable *LocalVar = Line2Var[Line];
It = Line2Var.try_emplace(Line).first;
}
DILocalVariable *LocalVar = It->second;
assert(LocalVar && "No variable for current line?");
VarSet.insert(LocalVar);

Expand Down