Skip to content

[Transforms] Avoid repeated hash lookups (NFC) #131497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025
Merged

[Transforms] Avoid repeated hash lookups (NFC) #131497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions llvm/lib/Transforms/IPO/FunctionAttrs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ static FunctionSummary *calculatePrevailingSummary(
function_ref<bool(GlobalValue::GUID, const GlobalValueSummary *)>
IsPrevailing) {

if (auto It = CachedPrevailingSummary.find(VI);
It != CachedPrevailingSummary.end())
auto [It, Inserted] = CachedPrevailingSummary.try_emplace(VI);
if (!Inserted)
return It->second;

/// At this point, prevailing symbols have been resolved. The following leads
Expand Down Expand Up @@ -363,7 +363,6 @@ static FunctionSummary *calculatePrevailingSummary(
/// future this can be revisited.
/// 5. Otherwise, go conservative.

CachedPrevailingSummary[VI] = nullptr;
FunctionSummary *Local = nullptr;
FunctionSummary *Prevailing = nullptr;

Expand Down Expand Up @@ -764,12 +763,12 @@ ArgumentUsesSummary collectArgumentUsesPerBlock(Argument &A, Function &F) {
auto UpdateUseInfo = [&Result](Instruction *I, ArgumentAccessInfo Info) {
auto *BB = I->getParent();
auto &BBInfo = Result.UsesPerBlock[BB];
bool AlreadyVisitedInst = BBInfo.Insts.contains(I);
auto &IInfo = BBInfo.Insts[I];
auto [It, Inserted] = BBInfo.Insts.try_emplace(I);
auto &IInfo = It->second;

// Instructions that have more than one use of the argument are considered
// as clobbers.
if (AlreadyVisitedInst) {
if (!Inserted) {
IInfo = {ArgumentAccessInfo::AccessType::Unknown, {}};
BBInfo.HasUnknownAccess = true;
return false;
Expand Down