Skip to content

[libc][sched] Implement CPU_ZERO, CPU_ISSET, CPU_SET macros #131524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lntue merged 14 commits into from
Mar 19, 2025
Merged

[libc][sched] Implement CPU_ZERO, CPU_ISSET, CPU_SET macros #131524

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
365fe47
feat: implement CPU_ZERO[_S] macros
krishna2803 Mar 15, 2025
862d702
feat: add entrypoint for __sched_setcpuzero
krishna2803 Mar 16, 2025
b0af3f5
feat: implement CPU_SETSIZE and NCPUBITS
krishna2803 Mar 16, 2025
4dc2371
feat: implement CPU_SET[_S] macros
krishna2803 Mar 16, 2025
a21734f
chore: fix typo `LLVM_LIBC_FUNCTION` -> `LIBC_NAMESPACE_DECL`
krishna2803 Mar 16, 2025
dd7f3f6
chore: fix typo: `int` -> `void`
krishna2803 Mar 16, 2025
b21ccb3
feat: implement header for sched_macros
krishna2803 Mar 16, 2025
597b872
chore: fix fullbuild bugs
krishna2803 Mar 16, 2025
96e2378
feat: implement CPU_ISSET[_S] macro and fix CPU_SET[_S] macro
krishna2803 Mar 16, 2025
4e33001
chore: fix typo `__NCPUBITS8` -> `__NCPUBITS`
krishna2803 Mar 16, 2025
9a6ad67
fix: implicit conversion error
krishna2803 Mar 16, 2025
c94712f
chore: add parens
krishna2803 Mar 16, 2025
522c669
chore: add nullptr gaurds
krishna2803 Mar 18, 2025
9b0d165
chore: add `__support` dependencies in CMakeLists.txt
krishna2803 Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libc/src/sched/linux/sched_getcpuisset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@

#include "src/sched/sched_getcpuisset.h"

#include "src/__support/common.h" // LLVM_LIBC_FUNCTION
#include "src/__support/macros/config.h" // LIBC_NAMESPACE_DECL
#include "src/__support/common.h" // LLVM_LIBC_FUNCTION
Copy link
Contributor

@lntue lntue Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Update the cmake dependency of these targets.

Copy link
Contributor Author

@krishna2803 krishna2803 Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! 9b0d165e

#include "src/__support/macros/config.h" // LIBC_NAMESPACE_DECL
#include "src/__support/macros/null_check.h" // LIBC_CRASH_ON_NULLPTR

#include "hdr/sched_macros.h" // NCPUBITS
#include "hdr/types/cpu_set_t.h"
Expand All @@ -19,6 +20,8 @@ namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(int, __sched_getcpuisset,
(int cpu, const size_t cpuset_size, cpu_set_t *set)) {
LIBC_CRASH_ON_NULLPTR(set);

if (static_cast<size_t>(cpu) / 8 < cpuset_size) {
const size_t element_index = static_cast<size_t>(cpu) / NCPUBITS;
const size_t bit_position = static_cast<size_t>(cpu) % NCPUBITS;
Expand Down
6 changes: 4 additions & 2 deletions libc/src/sched/linux/sched_setcpuset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@

#include "src/sched/sched_setcpuset.h"

#include "src/__support/common.h" // LLVM_LIBC_FUNCTION
#include "src/__support/macros/config.h" // LIBC_NAMESPACE_DECL
#include "src/__support/common.h" // LLVM_LIBC_FUNCTION
#include "src/__support/macros/config.h" // LIBC_NAMESPACE_DECL
#include "src/__support/macros/null_check.h" // LIBC_CRASH_ON_NULLPTR

#include "hdr/sched_macros.h" // NCPUBITS
#include "hdr/types/cpu_set_t.h"
Expand All @@ -19,6 +20,7 @@ namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(void, __sched_setcpuset,
(int cpu, const size_t cpuset_size, cpu_set_t *set)) {
LIBC_CRASH_ON_NULLPTR(set);
if (static_cast<size_t>(cpu) / 8 < cpuset_size) {
const size_t element_index = static_cast<size_t>(cpu) / NCPUBITS;
const size_t bit_position = static_cast<size_t>(cpu) % NCPUBITS;
Expand Down
6 changes: 4 additions & 2 deletions libc/src/sched/linux/sched_setcpuzero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@

#include "src/sched/sched_setcpuzero.h"

#include "src/__support/common.h" // LLVM_LIBC_FUNCTION
#include "src/__support/macros/config.h" // LIBC_NAMESPACE_DECL
#include "src/__support/common.h" // LLVM_LIBC_FUNCTION
#include "src/__support/macros/config.h" // LIBC_NAMESPACE_DECL
#include "src/__support/macros/null_check.h" // LIBC_CRASH_ON_NULLPTR

#include "hdr/types/cpu_set_t.h"
#include "hdr/types/size_t.h"
Expand All @@ -18,6 +19,7 @@ namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(void, __sched_setcpuzero,
(const size_t cpuset_size, cpu_set_t *set)) {
LIBC_CRASH_ON_NULLPTR(set);
__builtin_memset(set, 0, cpuset_size);
}

Expand Down
Loading