Skip to content

[libc++] Fix allocate_at_least test that assumes the size_type of the allocator #131682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

[libc++] Fix allocate_at_least test that assumes the size_type of the allocator #131682

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e2568b
[libc++] Fix allocate_at_least test that assumes the size_type of the…
ldionne Mar 17, 2025
cd454fd
Fix template param
ldionne Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...std/utilities/memory/allocator.traits/allocator.traits.members/allocate_at_least.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,18 @@ struct has_allocate_at_least {
constexpr bool test() {
{ // check that std::allocate_at_least forwards to allocator::allocate if no allocate_at_least exists
no_allocate_at_least<int> alloc;
std::same_as<std::allocation_result<int*>> decltype(auto) ret =
std::allocator_traits<decltype(alloc)>::allocate_at_least(alloc, 1);
using AllocTraits = std::allocator_traits<decltype(alloc)>;
std::same_as<std::allocation_result<int*>, AllocTraits::size_type> decltype(auto) ret =
AllocTraits::allocate_at_least(alloc, 1);
assert(ret.count == 1);
assert(ret.ptr == &alloc.t);
}

{ // check that std::allocate_at_least forwards to allocator::allocate_at_least if allocate_at_least exists
has_allocate_at_least<int> alloc;
std::same_as<std::allocation_result<int*>> decltype(auto) ret =
std::allocator_traits<decltype(alloc)>::allocate_at_least(alloc, 1);
using AllocTraits = std::allocator_traits<decltype(alloc)>;
std::same_as<std::allocation_result<int*>, AllocTraits::size_type> decltype(auto) ret =
AllocTraits::allocate_at_least(alloc, 1);
assert(ret.count == 2);
assert(ret.ptr == &alloc.t2);
}
Expand Down
Loading