Unify x64 and arm64 build process in build_llvm_release.bat #131687
Conversation
|
@zmodem ping! |
|
I think the comment about retries is still not addressed? |
|
zmodem
left a comment
zmodem
left a comment
There was a problem hiding this comment.
Thanks!
I didn't actually try it, but this basically lgtm with the check-sanitizer comment addressed.
| -DLLVM_ENABLE_RPMALLOC=ON ^ | ||
| -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;compiler-rt;lldb;openmp" | ||
| -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld" ^ | ||
| -DLLVM_ENABLE_RUNTIMES="compiler-rt;openmp" |
There was a problem hiding this comment.
I have a feeling switching to the runtimes build is going to break us somehow, but I don't know how yet :)
This patch unifies x64 and arm64 build process in Windows release script by consolidating common functionality while preserving architecture specific requirements. Key changes include: - Combined x64 and arm64 build logic into do_build_64_common - Added PGO support for arm64 builds - Added flang and mlir projects to x64 builds - Remove LLDB from stage 0 builds and consolidate common LLDB flags - Build sanitizers for x64 while disable them on arm64.
omjavaid
force-pushed
the
win_rel_script_updates
branch
from
04ae3a4 to
0563d50
Compare
@zmodem Hi can we merge this patch. I have been doing LLVM windows on Arm build using this version of script for 21.x and its worked well for me so far. if you dont have any objections then i can merge it now. |
Some followups after #131687 switched to the "runtimes build". - The `check-sanitizer` build target doesn't exist in the runtimes build; use `check-runtimes` instead. - ASan is not supported on 32-bit windows. Pass `-DCOMPILER_RT_BUILD_SANITIZERS=OFF` - `check-runtimes` includes the orcjit tests, which never passed on windows; build with `-DCOMPILER_RT_BUILD_ORC=OFF` - Various asan and libfuzzer tests fail; suppress them with `LIT_FILTER_OUT`
2 participants
This patch unifies x64 and arm64 build process in Windows release script by consolidating common functionality while preserving architecture specific requirements.
Key changes include: