[NFC] Add a leading comment to boolean arguments. #131746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Michael Park (mpark) ChangesAddressing nit comments from @shafik Full diff: https://github.com/llvm/llvm-project/pull/131746.diff 2 Files Affected:
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 2c73501821bff..2b03446aaa30e 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -10825,7 +10825,8 @@ void ASTReader::FinishedDeserializing() {
{
// Guard variable to avoid recursively entering the process of passing
// decls to consumer.
- SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, false);
+ SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+ /*NewValue=*/false);
// Propagate exception specification and deduced type updates along
// redeclaration chains.
diff --git a/clang/lib/Serialization/ASTReaderDecl.cpp b/clang/lib/Serialization/ASTReaderDecl.cpp
index 79bd41aa2644e..c3341e00bacef 100644
--- a/clang/lib/Serialization/ASTReaderDecl.cpp
+++ b/clang/lib/Serialization/ASTReaderDecl.cpp
@@ -4314,7 +4314,8 @@ void ASTReader::PassInterestingDeclsToConsumer() {
// Guard variable to avoid recursively redoing the process of passing
// decls to consumer.
- SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, false);
+ SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+ /*NewValue=*/false);
// Ensure that we've loaded all potentially-interesting declarations
// that need to be eagerly loaded.
|
Member
|
@llvm/pr-subscribers-clang-modules Author: Michael Park (mpark) ChangesAddressing nit comments from @shafik Full diff: https://github.com/llvm/llvm-project/pull/131746.diff 2 Files Affected:
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 2c73501821bff..2b03446aaa30e 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -10825,7 +10825,8 @@ void ASTReader::FinishedDeserializing() {
{
// Guard variable to avoid recursively entering the process of passing
// decls to consumer.
- SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, false);
+ SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+ /*NewValue=*/false);
// Propagate exception specification and deduced type updates along
// redeclaration chains.
diff --git a/clang/lib/Serialization/ASTReaderDecl.cpp b/clang/lib/Serialization/ASTReaderDecl.cpp
index 79bd41aa2644e..c3341e00bacef 100644
--- a/clang/lib/Serialization/ASTReaderDecl.cpp
+++ b/clang/lib/Serialization/ASTReaderDecl.cpp
@@ -4314,7 +4314,8 @@ void ASTReader::PassInterestingDeclsToConsumer() {
// Guard variable to avoid recursively redoing the process of passing
// decls to consumer.
- SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, false);
+ SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+ /*NewValue=*/false);
// Ensure that we've loaded all potentially-interesting declarations
// that need to be eagerly loaded.
|
hstk30-hw
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing nit comments from @shafik