Skip to content

[lldb-dap] Ensure logging statements are written as a single chunk. #131916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 19, 2025
Merged

[lldb-dap] Ensure logging statements are written as a single chunk. #131916

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6aa311a
[lldb-dap] Ensure logging statements are written as a single atomic c…
ashgti Mar 18, 2025
d4a03fa
Using a small `class Log` wrapper around a mutex + ofstream to protec…
ashgti Mar 18, 2025
8d66eb2
Adding some documentation to lldb_dap::Log and moving the impl out of…
ashgti Mar 18, 2025
2b37022
With the helper type we can move the timestamp logic into the Log::Wr…
ashgti Mar 19, 2025
9fec66a
Adding lldb_dap::Log to the DAPForward.h.
ashgti Mar 19, 2025
279cefb
Using lock_guard instead of scoped_lock
ashgti Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions lldb/tools/lldb-dap/DAPLog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@
if (log_private) { \
::std::chrono::duration<double> now{ \
::std::chrono::system_clock::now().time_since_epoch()}; \
*log_private << ::llvm::formatv("{0:f9} ", now.count()).str() \
<< ::llvm::formatv(__VA_ARGS__).str() << std::endl; \
::std::string out; \
::llvm::raw_string_ostream os(out); \
os << ::llvm::formatv("{0:f9} ", now.count()).str() \
<< ::llvm::formatv(__VA_ARGS__).str() << "\n"; \
*log_private << out; \
log_private->flush(); \
} \
} while (0)

Expand All @@ -37,10 +41,13 @@
if (log_private && error_private) { \
::std::chrono::duration<double> now{ \
std::chrono::system_clock::now().time_since_epoch()}; \
*log_private << ::llvm::formatv("{0:f9} ", now.count()).str() \
<< ::lldb_dap::FormatError(::std::move(error_private), \
__VA_ARGS__) \
<< std::endl; \
::std::string out; \
::llvm::raw_string_ostream os(out); \
os << ::llvm::formatv("{0:f9} ", now.count()).str() \
<< ::lldb_dap::FormatError(::std::move(error_private), __VA_ARGS__) \
<< "\n"; \
*log_private << out; \
log_private->flush(); \
} else \
::llvm::consumeError(::std::move(error_private)); \
} while (0)
Expand Down
Loading