Skip to content

[libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION #131921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2025
Merged

[libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION #131921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f0da2b
[libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION
ldionne Mar 18, 2025
1d66f2d
Move placement of #if condition for consistency
ldionne Mar 19, 2025
9260a0d
Include <picolibc.h> to detect _NEWLIB_VERSION
ldionne Mar 26, 2025
84c6a28
Try fixing picolibc
ldionne Mar 28, 2025
620eb8d
frozen 03 headers
ldionne Mar 31, 2025
82cdc64
Also guard strstream
ldionne Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libcxx/include/__configuration/platform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@
# endif
#endif

// This is required in order for _NEWLIB_VERSION to be defined in places where we use it.
// TODO: We shouldn't be including arbitrarily-named headers from libc++ since this can break valid
// user code. Move code paths that need _NEWLIB_VERSION to another customization mechanism.
#if __has_include(<picolibc.h>)
# include <picolibc.h>
#endif

#ifndef __BYTE_ORDER__
# error \
"Your compiler doesn't seem to define __BYTE_ORDER__, which is required by libc++ to know the endianness of your target platform"
Expand Down
Loading