[lldb] Require wide char support in unicode test #131951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unicode test sends some unicode input to lldb through pexpect and expects the output to be echoed back in an error message. This only works correctly when editline was compiled with wide character support. This commit modifies the test to require the necessary libedit configuration.
Member
|
@llvm/pr-subscribers-lldb Author: David Peixotto (dmpots) ChangesThe unicode test sends some unicode input to lldb through pexpect and expects the output to be echoed back in an error message. This only works correctly when editline was compiled with wide character support. This commit modifies the test to require the necessary libedit configuration. Full diff: https://github.com/llvm/llvm-project/pull/131951.diff 1 Files Affected:
diff --git a/lldb/test/API/iohandler/unicode/TestUnicode.py b/lldb/test/API/iohandler/unicode/TestUnicode.py
index 93e2ae38f8262..f13427f2c30a8 100644
--- a/lldb/test/API/iohandler/unicode/TestUnicode.py
+++ b/lldb/test/API/iohandler/unicode/TestUnicode.py
@@ -16,6 +16,7 @@ class TestCase(PExpectTest):
# under ASAN on a loaded machine..
@skipIfAsan
@skipIf(oslist=["linux"], archs=["arm", "aarch64"]) # Randomly fails on buildbot
+ @skipIfEditlineWideCharSupportMissing
def test_unicode_input(self):
self.launch()
|
JDevlieghere
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unicode test sends some unicode input to lldb through pexpect and expects the output to be echoed back in an error message. This only works correctly when editline was compiled with wide character support.
This commit modifies the test to require the necessary libedit configuration.