Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 19, 2025

@llvm/pr-subscribers-backend-x86

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/131963.diff

1 Files Affected:

  • (modified) llvm/lib/Target/X86/X86DiscriminateMemOps.cpp (+2-2)
diff --git a/llvm/lib/Target/X86/X86DiscriminateMemOps.cpp b/llvm/lib/Target/X86/X86DiscriminateMemOps.cpp
index 6c7e6bf041995..bd151a450394a 100644
--- a/llvm/lib/Target/X86/X86DiscriminateMemOps.cpp
+++ b/llvm/lib/Target/X86/X86DiscriminateMemOps.cpp
@@ -113,8 +113,8 @@ bool X86DiscriminateMemOps::runOnMachineFunction(MachineFunction &MF) {
       if (BypassPrefetchInstructions && IsPrefetchOpcode(MI.getDesc().Opcode))
         continue;
       Location Loc = diToLocation(DI);
-      MemOpDiscriminators[Loc] =
-          std::max(MemOpDiscriminators[Loc], DI->getBaseDiscriminator());
+      unsigned &Disc = MemOpDiscriminators[Loc];
+      Disc = std::max(Disc, DI->getBaseDiscriminator());
     }
   }
 

@kazutakahirata kazutakahirata merged commit 364e60b into llvm:main Mar 19, 2025
11 of 13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_repeated_hash_lookups_llvm_X86 branch March 19, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants