Skip to content

[clang][CodeGen][AVR] Fix a crash in AVRABIInfo #131976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2025
Merged

[clang][CodeGen][AVR] Fix a crash in AVRABIInfo #131976

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
163c73d
[clang][CodeGen][AVR] Fix a crash in AVRABIInfo
benshi001 Mar 19, 2025
db000cf
[clang][CodeGen][AVR] Fix a crash in AVRABIInfo
benshi001 Mar 20, 2025
3864ab2
fix test
benshi001 Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions clang/lib/CodeGen/Targets/AVR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class AVRABIInfo : public DefaultABIInfo {
unsigned TySize = getContext().getTypeSize(Ty);

// An int8 type argument always costs two registers like an int16.
if (TySize == 8 && NumRegs >= 2) {
if (TySize == 8 && NumRegs >= 2 && Ty->isIntegralOrEnumerationType()) {
NumRegs -= 2;
return ABIArgInfo::getExtend(Ty);
}
Expand Down Expand Up @@ -135,7 +135,8 @@ class AVRTargetCodeGenInfo : public TargetCodeGenInfo {
if (GV->isDeclaration())
return;
const auto *FD = dyn_cast_or_null<FunctionDecl>(D);
if (!FD) return;
if (!FD)
return;
auto *Fn = cast<llvm::Function>(GV);

if (FD->getAttr<AVRInterruptAttr>())
Expand All @@ -145,7 +146,7 @@ class AVRTargetCodeGenInfo : public TargetCodeGenInfo {
Fn->addFnAttr("signal");
}
};
}
} // namespace

std::unique_ptr<TargetCodeGenInfo>
CodeGen::createAVRTargetCodeGenInfo(CodeGenModule &CGM, unsigned NPR,
Expand Down
10 changes: 10 additions & 0 deletions clang/test/CodeGen/avr/argument.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,13 @@ struct s15 fooa(char a, char b) {
x.arr[1] = b;
return x;
}

struct s8_t {
char a;
};

// AVR-NOT: {{.*}} signext
// TINY-NOT: {{.*}} signext
char foob(struct s8_t a) {
return a.a + 1;
}