Skip to content

Conversation

@klausler
Copy link
Contributor

Now that COMPLEX(KIND=10) is properly disabled where 80-bit floating-point types are not available, three tests that were not peculiar to x86-64 are failing on other targets. Make them specific to x86-64.

Now that COMPLEX(KIND=10) is properly disabled where 80-bit floating-point
types are not available, three tests that were not peculiar to x86-64
are failing on other targets.  Make them specific to x86-64.
@klausler klausler requested a review from clementval March 19, 2025 19:51
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Mar 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 19, 2025

@llvm/pr-subscribers-flang-fir-hlfir

Author: Peter Klausler (klausler)

Changes

Now that COMPLEX(KIND=10) is properly disabled where 80-bit floating-point types are not available, three tests that were not peculiar to x86-64 are failing on other targets. Make them specific to x86-64.


Full diff: https://github.com/llvm/llvm-project/pull/132088.diff

3 Files Affected:

  • (modified) flang/test/Lower/Intrinsics/product.f90 (+1)
  • (modified) flang/test/Lower/Intrinsics/sum.f90 (+1)
  • (modified) flang/test/Lower/complex-operations.f90 (+1)
diff --git a/flang/test/Lower/Intrinsics/product.f90 b/flang/test/Lower/Intrinsics/product.f90
index b2fc809b15ef3..f5f7cff106cee 100644
--- a/flang/test/Lower/Intrinsics/product.f90
+++ b/flang/test/Lower/Intrinsics/product.f90
@@ -1,3 +1,4 @@
+! REQUIRES: x86_64-registered-target
 ! RUN: bbc --use-desc-for-alloc=false -emit-fir -hlfir=false %s -o - | FileCheck %s
 
 ! CHECK-LABEL: func @_QPproduct_test(
diff --git a/flang/test/Lower/Intrinsics/sum.f90 b/flang/test/Lower/Intrinsics/sum.f90
index 785f20b861f13..d36b2b1263887 100644
--- a/flang/test/Lower/Intrinsics/sum.f90
+++ b/flang/test/Lower/Intrinsics/sum.f90
@@ -1,3 +1,4 @@
+! REQUIRES: x86_64-registered-target
 ! RUN: bbc --use-desc-for-alloc=false -emit-fir -hlfir=false %s -o - | FileCheck %s
 
 ! CHECK-LABEL: func @_QPsum_test(
diff --git a/flang/test/Lower/complex-operations.f90 b/flang/test/Lower/complex-operations.f90
index ccf418e9ad5aa..fdd13719c5b71 100644
--- a/flang/test/Lower/complex-operations.f90
+++ b/flang/test/Lower/complex-operations.f90
@@ -1,4 +1,5 @@
 ! REQUIRES: flang-supports-f128-math
+! REQUIRES: x86_64-registered-target
 ! RUN: bbc -hlfir=false %s -o - | FileCheck %s
 
 ! CHECK-LABEL: @_QPadd_test

@klausler klausler merged commit a0ae88b into llvm:main Mar 19, 2025
9 of 13 checks passed
@klausler klausler deleted the fix-tests branch March 19, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:fir-hlfir flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants