Skip to content

[libc++] Ensure that we vectorize algorithms on all Clang-based compilers #132090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2025
Merged

[libc++] Ensure that we vectorize algorithms on all Clang-based compilers #132090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1502090
[libc++] Ensure that we vectorize algorithms on all Clang-based compi…
ldionne Mar 19, 2025
20e2350
Add XFAILs
ldionne Mar 20, 2025
c34e7a2
Test the test
ldionne Mar 20, 2025
427dd72
Add temporary workaround for AppleClang 15 until we drop CI for it
ldionne Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libcxx/include/__algorithm/simd_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ _LIBCPP_PUSH_MACROS
#include <__undef_macros>

// TODO: Find out how altivec changes things and allow vectorizations there too.
#if _LIBCPP_STD_VER >= 14 && defined(_LIBCPP_CLANG_VER) && !defined(__ALTIVEC__)
// TODO: Simplify this condition once we stop building with AppleClang 15 in the CI.
#if _LIBCPP_STD_VER >= 14 && defined(_LIBCPP_COMPILER_CLANG_BASED) && !defined(__ALTIVEC__) && \
!(defined(_LIBCPP_APPLE_CLANG_VER) && _LIBCPP_APPLE_CLANG_VER < 1600)
# define _LIBCPP_HAS_ALGORITHM_VECTOR_UTILS 1
#else
# define _LIBCPP_HAS_ALGORITHM_VECTOR_UTILS 0
Expand Down
34 changes: 34 additions & 0 deletions libcxx/test/libcxx/algorithms/vectorization.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

// We don't know how to vectorize algorithms on GCC
// XFAIL: gcc

// XFAIL: FROZEN-CXX03-HEADERS-FIXME

// We don't vectorize algorithms before C++14
// XFAIL: c++03, c++11

// We don't vectorize algorithms on AIX right now.
// XFAIL: target={{.+}}-aix{{.*}}

// We don't vectorize on AppleClang 15 since that apparently breaks std::mismatch
// XFAIL: apple-clang-15

// This test ensures that we enable the vectorization of algorithms on the expected
// platforms.

#include <algorithm>

#ifndef _LIBCPP_VECTORIZE_ALGORITHMS
# error It looks like the test needs to be updated since _LIBCPP_VECTORIZE_ALGORITHMS isn't defined anymore
#endif

#if !_LIBCPP_VECTORIZE_ALGORITHMS
# error Algorithms should be vectorized on this platform
#endif
Loading