Skip to content

[lldb][debugserver] Interrupt should reset outstanding SIGSTOP #132128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonmolenda merged 1 commit into from
Mar 20, 2025
Merged

[lldb][debugserver] Interrupt should reset outstanding SIGSTOP #132128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lldb/tools/debugserver/source/MacOSX/MachProcess.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1594,6 +1594,10 @@ static uint64_t bits(uint64_t value, uint32_t msbit, uint32_t lsbit) {
m_sent_interrupt_signo);
}
} else {
// We've requested that the process stop anew; if we had recorded this
// requested stop as being in place when we resumed (& therefore would
// throw it away), clear that.
m_auto_resume_signo = 0;
Copy link
Member

@JDevlieghere JDevlieghere Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and this is protected by the m_exception_and_signal_mutex. 👍

Copy link
Collaborator Author

@jasonmolenda jasonmolenda Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you added that lock when you were addressing TSAN issues, it's definitely required.

DNBLogThreadedIf(LOG_PROCESS, "MachProcess::Interrupt() - previously "
"sent an interrupt signal %i that hasn't "
"been received yet, interrupt aborted",
Expand Down