Skip to content

[libc][uefi] add crt1 #132150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 9, 2025
Merged

[libc][uefi] add crt1 #132150

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b12c594
[libc][uefi] add crt1
RossComputerGuy Mar 20, 2025
dee779f
[libc][uefi] drop mingw compat in crt0
RossComputerGuy Mar 20, 2025
7428fe0
[libc][uefi] update efi symbols in efi main
RossComputerGuy Mar 21, 2025
bf566bb
[libc][uefi] add status codes
RossComputerGuy Mar 21, 2025
40a26a0
[libc][uefi] fix Uefi.h install name
RossComputerGuy Mar 22, 2025
e5a4692
[libc][uefi] add errno and uefi status conversion
RossComputerGuy Mar 22, 2025
d963ce2
[libc][uefi] fix error, exit, and io OSUtil support compilation
RossComputerGuy Mar 22, 2025
4ccc169
[libc][uefi] get error codes working
RossComputerGuy Mar 22, 2025
65da577
[libc][uefi] fix review
RossComputerGuy Mar 27, 2025
553ec1b
[libc][uefi] fix formatting
RossComputerGuy Mar 27, 2025
6648c0c
[libc][uefi] use cpp::array for the error map
RossComputerGuy Apr 1, 2025
0596ada
[libc][uefi] use LIBC_INLINE in error
RossComputerGuy Apr 2, 2025
f87345a
[libc][uefi] add startup integration test
RossComputerGuy Apr 2, 2025
0a47352
[libc][uefi] use cpp::numeric_limits for UEFI_STATUS_ERRNO_MAP
RossComputerGuy Apr 2, 2025
ae46dfc
[libc][uefi] move uefi system table & image to app config
RossComputerGuy Apr 24, 2025
5e4c64f
[libc] fix formatting
RossComputerGuy Apr 24, 2025
74dd600
[libc][uefi] use constexpr for errno map
RossComputerGuy Apr 24, 2025
3aaccf0
Merge branch 'main' into feat/libc-uefi/start
RossComputerGuy May 1, 2025
b5dbce3
[libc][uefi] review adjustments
RossComputerGuy May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libc/src/__support/OSUtil/uefi/error.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_OSUTIL_UEFI_ERROR_H
#define LLVM_LIBC_SRC___SUPPORT_OSUTIL_UEFI_ERROR_H

#include "hdr/errno_macros.h"
#include "include/llvm-libc-types/EFI_STATUS.h"
#include "src/__support/CPP/array.h"
#include "src/__support/CPP/limits.h"
#include "src/__support/macros/attributes.h"
#include "src/__support/macros/config.h"
#include <errno.h>
#include <limits.h>

namespace LIBC_NAMESPACE_DECL {

#define EFI_ERROR_MAX_BIT (1 << (sizeof(EFI_STATUS) * sizeof(char) - 1))
#define EFI_ERROR_MAX_BIT (cpp::numeric_limits<EFI_STATUS>::max())
#define EFI_ENCODE_ERROR(value) \
(EFI_ERROR_MAX_BIT | (EFI_ERROR_MAX_BIT >> 2) | (value))
#define EFI_ENCODE_WARNING(value) ((EFI_ERROR_MAX_BIT >> 2) | (value))
Expand All @@ -28,7 +28,7 @@ struct UefiStatusErrnoEntry {
int errno_value;
};

static constexpr cpp::array<UefiStatusErrnoEntry, 43> UEFI_STATUS_ERRNO_MAP = {{
static const cpp::array<UefiStatusErrnoEntry, 43> UEFI_STATUS_ERRNO_MAP = {{
Copy link
Contributor

@lntue lntue Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not constexpr?

Copy link
Member Author

@RossComputerGuy RossComputerGuy Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was causing a compiler error. I have about 2,370 builds to go until I can try.

Copy link
Member Author

@RossComputerGuy RossComputerGuy Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it turns out clang likes it now. 🤷

{EFI_SUCCESS, 0},
{EFI_ENCODE_ERROR(EFI_LOAD_ERROR), EINVAL},
{EFI_ENCODE_ERROR(EFI_INVALID_PARAMETER), EINVAL},
Expand Down
Loading