Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

No description provided.

Fixes error: unused variable 'is_steady' [-Werror,-Wunused-const-variable]
sized_allocator.h(40): warning C4244: 'argument': conversion from 'unsigned __int64' to 'const size_t', possible loss of data
sized_allocator.h(43): warning C4244: 'argument': conversion from 'unsigned __int64' to 'const size_t', possible loss of data

std::allocator takes std::size_t, so we need to static_cast.
offset_range.pass.cpp(49): warning C4244: 'initializing': conversion from 'const _Ty' to 'size_t', possible loss of data

std::min() is returning std::streamoff, which was being unnecessarily narrowed to std::size_t.
…ways-true branch.

This was very recently introduced by LLVM-129008 making `N` constexpr. As it's a local constant
just nine lines above, we don't need to test whether 100 is greater than 0.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 20, 2025 08:05
@StephanTLavavej StephanTLavavej deleted the stl-fixes branch March 20, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants