Skip to content

[CIR] Fix unary op folding #132269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

[CIR] Fix unary op folding #132269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee4e73
[CIR] Fix unary op folding
andykaylor Mar 20, 2025
9640f59
Test update
andykaylor Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion clang/include/clang/CIR/MissingFeatures.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ struct MissingFeatures {
static bool brCondOp() { return false; }
static bool switchOp() { return false; }
static bool tryOp() { return false; }
static bool unaryOp() { return false; }
static bool selectOp() { return false; }
static bool complexCreateOp() { return false; }
static bool complexRealOp() { return false; }
Expand Down
7 changes: 3 additions & 4 deletions clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,14 @@ void CIRCanonicalizePass::runOnOperation() {
assert(!cir::MissingFeatures::brCondOp());
assert(!cir::MissingFeatures::switchOp());
assert(!cir::MissingFeatures::tryOp());
assert(!cir::MissingFeatures::unaryOp());
assert(!cir::MissingFeatures::selectOp());
assert(!cir::MissingFeatures::complexCreateOp());
assert(!cir::MissingFeatures::complexRealOp());
assert(!cir::MissingFeatures::complexImagOp());
assert(!cir::MissingFeatures::callOp());
// CastOp here is to perform a manual `fold` in
// applyOpPatternsGreedily
if (isa<BrOp, ScopeOp, CastOp>(op))
// CastOp and UnaryOp are here to perform a manual `fold` in
// applyOpPatternsGreedily.
if (isa<BrOp, ScopeOp, CastOp, UnaryOp>(op))
ops.push_back(op);
});

Expand Down
8 changes: 8 additions & 0 deletions clang/test/CIR/Transforms/canonicalize.cir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ module {
// CHECK-NEXT: cir.return
// CHECK-NEXT: }

cir.func @unary_not(%arg0: !cir.bool) -> !cir.bool {
%0 = cir.unary(not, %arg0) : !cir.bool, !cir.bool
%1 = cir.unary(not, %0) : !cir.bool, !cir.bool
cir.return %1 : !cir.bool
}
// CHECK: cir.func @unary_not(%arg0: !cir.bool) -> !cir.bool
// CHECK-NEXT: cir.return %arg0 : !cir.bool

cir.func @cast1(%arg0: !cir.bool) -> !cir.bool {
%0 = cir.cast(bool_to_int, %arg0 : !cir.bool), !s32i
%1 = cir.cast(int_to_bool, %0 : !s32i), !cir.bool
Expand Down