Skip to content

[VPlan] Add extra checks for LoopForBB. NFC. #132306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[VPlan] Add extra checks for LoopForBB. NFC. #132306

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f96bc61
[VPlan] Add extra checks for LoopForBB. NFC.
offsake Mar 19, 2025
78063b2
[NFC][VPlan] Delete redundant check.
offsake Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ void PlainCFGBuilder::buildPlainCFG(
VPRegionBlock *Region = VPBB->getParent();
Loop *LoopForBB = LI->getLoopFor(BB);
// Set VPBB predecessors in the same order as they are in the incoming BB.
if (!isHeaderBB(BB, LoopForBB)) {
if (LoopForBB && !isHeaderBB(BB, LoopForBB)) {
setVPBBPredsFromBB(VPBB, BB);
} else if (Region) {
// BB is a loop header and there's a corresponding region, set the
Expand All @@ -390,7 +390,7 @@ void PlainCFGBuilder::buildPlainCFG(
// Create VPInstructions for BB.
createVPInstructionsForVPBB(VPBB, BB);

if (BB == TheLoop->getLoopLatch()) {
if (LoopForBB && BB == TheLoop->getLoopLatch()) {
VPBasicBlock *HeaderVPBB = getOrCreateVPBB(LoopForBB->getHeader());
VPBlockUtils::connectBlocks(VPBB, HeaderVPBB);
continue;
Expand Down Expand Up @@ -423,7 +423,7 @@ void PlainCFGBuilder::buildPlainCFG(
BasicBlock *IRSucc1 = BI->getSuccessor(1);
VPBasicBlock *Successor0 = getOrCreateVPBB(IRSucc0);
VPBasicBlock *Successor1 = getOrCreateVPBB(IRSucc1);
if (BB == LoopForBB->getLoopLatch()) {
if (LoopForBB && BB == LoopForBB->getLoopLatch()) {
// For a latch we need to set the successor of the region rather than that
// of VPBB and it should be set to the exit, i.e., non-header successor,
// except for the top region, which is handled elsewhere.
Expand Down