WIP: [clang] store sugared converted arguments on TemplateSpecializationType #132439
+695
−598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizvekov
force-pushed
the
users/mizvekov/clang-sugar-sugared-converted-tst
branch
from
6f70503 to
8ccbff4
Compare
…ionType Not ready for review This is a quite large patch, half of which will be redone following a different approach. Although it improves sugar retention in template argument deduction on its own, this is an enabler for resugaring. This stores the sugared converted template arguments in a TST, in addition to the existing as-written ones, so this is quite wasteful. This is the biggest performance impact on the whole of resugaring so far, although it is hoped the new approach will have negligible impact. This is a continuation of https://reviews.llvm.org/D134113
mizvekov
force-pushed
the
users/mizvekov/clang-sugar-sugared-converted-tst
branch
from
8ccbff4 to
5b6f71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quite large patch, half of which will
be redone following a different approach.
Although it improves sugar retention in template argument deduction on its own, this is an enabler for resugaring.
This stores the sugared converted template arguments in a TST, in addition to the existing as-written ones, so this is quite wasteful.
This is the biggest performance impact on the whole of resugaring so far, although it is hoped the
new approach will have negligible impact.
This is a continuation of https://reviews.llvm.org/D134113