Skip to content

[webkit.RefCntblBaseVirtualDtor] Add support for NoVirtualDestructorBase. #132497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

[webkit.RefCntblBaseVirtualDtor] Add support for NoVirtualDestructorBase. #132497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion clang/lib/StaticAnalyzer/Checkers/WebKit/RefCntblBaseVirtualDtorChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,13 @@ class RefCntblBaseVirtualDtorChecker
if (!C)
continue;

bool isExempt = T.getAsString() == "NoVirtualDestructorBase" &&
safeGetName(C->getParent()) == "WTF";
if (isExempt || ExemptDecls.contains(C)) {
ExemptDecls.insert(RD);
continue;
}

if (auto *CTSD = dyn_cast<ClassTemplateSpecializationDecl>(C)) {
for (auto &Arg : CTSD->getTemplateArgs().asArray()) {
if (Arg.getKind() != TemplateArgument::Type)
Expand All @@ -223,12 +230,13 @@ class RefCntblBaseVirtualDtorChecker

llvm::SetVector<const CXXRecordDecl *> Decls;
llvm::DenseSet<const CXXRecordDecl *> CRTPs;
llvm::DenseSet<const CXXRecordDecl *> ExemptDecls;
};

LocalVisitor visitor(this);
visitor.TraverseDecl(const_cast<TranslationUnitDecl *>(TUD));
for (auto *RD : visitor.Decls) {
if (visitor.CRTPs.contains(RD))
if (visitor.CRTPs.contains(RD) || visitor.ExemptDecls.contains(RD))
continue;
visitCXXRecordDecl(RD);
}
Expand Down
17 changes: 17 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/ref-cntbl-base-virtual-dtor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=webkit.RefCntblBaseVirtualDtor -verify %s

namespace WTF {

class NoVirtualDestructorBase { };

};

using WTF::NoVirtualDestructorBase;

struct RefCntblBase {
void ref() {}
void deref() {}
Expand All @@ -19,6 +27,15 @@ struct [[clang::suppress]] SuppressedDerivedWithVirtualDtor : RefCntblBase {
virtual ~SuppressedDerivedWithVirtualDtor() {}
};

class ClassWithoutVirtualDestructor : public NoVirtualDestructorBase {
public:
void ref() const;
void deref() const;
};

class DerivedClassWithoutVirtualDestructor : public ClassWithoutVirtualDestructor {
};

// FIXME: Support attributes on base specifiers? Currently clang
// doesn't support such attributes at all, even though it knows
// how to parse them.
Expand Down