Skip to content

Conversation

@llvmbot
Copy link
Member

@llvmbot llvmbot commented Mar 22, 2025

Backport 94426df

Requested by: @j-hui

@llvmbot
Copy link
Member Author

llvmbot commented Mar 22, 2025

@llvm/pr-subscribers-pgo

Author: None (llvmbot)

Changes

Backport 94426df

Requested by: @j-hui


Full diff: https://github.com/llvm/llvm-project/pull/132506.diff

1 Files Affected:

  • (modified) compiler-rt/test/profile/instrprof-darwin-exports.c (+3-3)
diff --git a/compiler-rt/test/profile/instrprof-darwin-exports.c b/compiler-rt/test/profile/instrprof-darwin-exports.c
index 079d5d28ed24d..1a2ac8c813272 100644
--- a/compiler-rt/test/profile/instrprof-darwin-exports.c
+++ b/compiler-rt/test/profile/instrprof-darwin-exports.c
@@ -7,13 +7,13 @@
 // just "_main" produces no warnings or errors.
 //
 // RUN: echo "_main" > %t.exports
-// RUN: %clang_pgogen -Werror -Wl,-exported_symbols_list,%t.exports -o %t %s 2>&1 | tee %t.log
-// RUN: %clang_profgen -Werror -fcoverage-mapping -Wl,-exported_symbols_list,%t.exports -o %t %s 2>&1 | tee -a %t.log
+// RUN: %clang_pgogen -Werror -Wl,-exported_symbols_list,%t.exports -Wl,-w -o %t %s 2>&1 | tee %t.log
+// RUN: %clang_profgen -Werror -fcoverage-mapping -Wl,-exported_symbols_list,%t.exports -Wl,-w -o %t %s 2>&1 | tee -a %t.log
 // RUN: cat %t.log | count 0
 
 // 2) Ditto (1), but for GCOV.
 //
-// RUN: %clang -Werror -Wl,-exported_symbols_list,%t.exports --coverage -o %t.gcov %s | tee -a %t.gcov.log
+// RUN: %clang -Werror -Wl,-exported_symbols_list,%t.exports -Wl,-w --coverage -o %t.gcov %s | tee -a %t.gcov.log
 // RUN: cat %t.gcov.log | count 0
 
 // 3) The default set of weak external symbols should match the set of symbols

@j-hui
Copy link

j-hui commented Mar 24, 2025

@dtellenbach I'm unable to add you as a reviewer/merge this myself; could you please take a look at this PR? Thank you!

@dtellenbach
Copy link
Member

@dtellenbach I'm unable to add you as a reviewer/merge this myself; could you please take a look at this PR? Thank you!

@j-hui, the LLVM release managers will take it from here and merge this once they get around to it.

@dtellenbach dtellenbach requested review from dtellenbach and removed request for dtellenbach March 24, 2025 18:26
@tstellar tstellar moved this from Needs Triage to Needs Review in LLVM Release Status Mar 25, 2025
@tstellar tstellar moved this from Needs Review to Needs Merge in LLVM Release Status Mar 25, 2025
…1425)

ld64 issues a warning about section alignment which was counted as an
unexpected exported symbol and the test failed.

Fixed by disabling all linker warnings using -Wl,-w.

(cherry picked from commit 94426df)
@tstellar tstellar merged commit 2198410 into llvm:release/20.x Mar 25, 2025
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in LLVM Release Status Mar 25, 2025
@github-actions
Copy link

@j-hui (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler-rt PGO Profile Guided Optimizations

Projects

Development

Successfully merging this pull request may close these issues.

4 participants