[NFC][mlir][bufferization] #132637
Merged
[NFC][mlir][bufferization] #132637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix comment.
Member
|
@llvm/pr-subscribers-mlir-bufferization Author: Javed Absar (javedabsar1) ChangesFix comment. Full diff: https://github.com/llvm/llvm-project/pull/132637.diff 1 Files Affected:
diff --git a/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir b/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir
index 4d91249bbd714..8249d59b2374e 100644
--- a/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir
+++ b/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir
@@ -123,7 +123,7 @@ func.func @insertion_point_outside_loop(%t : tensor<?xf32>, %sz : index,
// -----
-// EmptyTensorElimination does currently not apply to chains where the type is
+// EmptyTensorElimination does not currently apply to chains where the type is
// changing. (Casts are supported.) This test just ensures that we do not crash
// or generate IR that does not verify.
|
Member
|
@llvm/pr-subscribers-mlir Author: Javed Absar (javedabsar1) ChangesFix comment. Full diff: https://github.com/llvm/llvm-project/pull/132637.diff 1 Files Affected:
diff --git a/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir b/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir
index 4d91249bbd714..8249d59b2374e 100644
--- a/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir
+++ b/mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir
@@ -123,7 +123,7 @@ func.func @insertion_point_outside_loop(%t : tensor<?xf32>, %sz : index,
// -----
-// EmptyTensorElimination does currently not apply to chains where the type is
+// EmptyTensorElimination does not currently apply to chains where the type is
// changing. (Casts are supported.) This test just ensures that we do not crash
// or generate IR that does not verify.
|
matthias-springer
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix comment.