Skip to content

Retry for Unique Path Creation #132640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushpareek2003 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retry for Unique Path Creation #132640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,9 +750,25 @@ bool DependencyScanningWorker::computeDependencies(
auto InMemoryFS = llvm::makeIntrusiveRefCnt<llvm::vfs::InMemoryFileSystem>();
InMemoryFS->setCurrentWorkingDirectory(WorkingDirectory);
SmallString<128> FakeInputPath;
// TODO: We should retry the creation if the path already exists.
llvm::sys::fs::createUniquePath(ModuleName + "-%%%%%%%%.input", FakeInputPath,
/*MakeAbsolute=*/false);

unsigned RetryCount = 5; // retries to create
bool UniquePathCreated = false;

for (unsigned i = 0; i < RetryCount; ++i) {
if (llvm::sys::fs::createUniquePath(ModuleName + "-%%%%%%%%.input", FakeInputPath,
/*MakeAbsolute=*/false)) {
if (!llvm::sys::fs::exists(FakeInputPath)) {
UniquePathCreated = true;
break; // Successfully created a unique path
}
}
}
if (!UniquePathCreated) {
llvm::errs() << "Error: Failed to create a unique input path after "
<< RetryCount << " retries.\n";
return false; // Handle failure appropriately
}

InMemoryFS->addFile(FakeInputPath, 0, llvm::MemoryBuffer::getMemBuffer(""));
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> InMemoryOverlay = InMemoryFS;

Expand Down