[Flang][OpenMP] Add OpenMP standards support doc #132707
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,62 @@ | ||||||
| <!--===- docs/FortranStandardsSupport.md | ||||||
|
|
||||||
| Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||||||
| See https://llvm.org/LICENSE.txt for license information. | ||||||
| SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||||||
|
|
||||||
| --> | ||||||
|
|
||||||
| # Flang OpenMP Standards Support | ||||||
|
|
||||||
| ```{contents} | ||||||
| --- | ||||||
| local: | ||||||
| --- | ||||||
| ``` | ||||||
|
|
||||||
| This document summarizes OpenMP standards support in Flang. The information is only provided as a guideline. The | ||||||
| TODOs/Not Yet Implemented messages emitted by the compiler for unimplemented features should be treated as authoritative. | ||||||
| Standards support is provided upto OpenMP 4.0 for now. It will be extended later for OpenMP 4.5, OpenMP 5.* and OpenMP 6.0. | ||||||
|
||||||
| Standards support is provided upto OpenMP 4.0 for now. It will be extended later for OpenMP 4.5, OpenMP 5.* and OpenMP 6.0. | |
| As of March 2025, standards support is provided upto OpenMP 4.0. It will be extended later for OpenMP 4.5, OpenMP 5.* and OpenMP 6.0. |
Are we working on support for OpenMP > 4.0? If so, perhaps the second sentence could be rephrased to better reflect this. Perhaps
We are actively working towards supporting OpenMP 4.5, OpenMP 5.* and OpenMP 6.0.
Contributor
Author
There was a problem hiding this comment.
Are we working on support for OpenMP > 4.0?
Yes. Some might be working already. Just that I have not spent time characterising the support.
Your suggestions look good. Have made the change.
Outdated
Contributor
There was a problem hiding this comment.
Might want to explain that this is Yes/No/Partial (presumably)
Outdated
Contributor
There was a problem hiding this comment.
Another optional rephrase (if I understand your intent correctly)
Suggested change
| Note : No distinction is made between the support in the Parser/Semantics, MLIR or Lowering support, and OpenMPIRBuilder support. | |
| Note : No distinction is made between the support in Parser/Semantics, MLIR, Lowering or the OpenMPIRBuilder. |
tblah marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
tblah marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
tblah marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
tblah marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
Contributor
Author
There was a problem hiding this comment.
I am conservatively marking all target-related constructs (including combined ones) as Partial support. I can correct the entries if they are fully supported.
Outdated
Contributor
There was a problem hiding this comment.
Should these corner cases be made explicit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(OpenMP is not a standard in the true sense, like with the ISO standards.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be OK to go with OpenMP specification?
This document summarizes the supported features of the OpenMP specification in FlangThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.