[OpenMP] Add memory allocation using hwloc #132843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for memory allocation using hwloc. To enable memory allocation using hwloc, env KMP_TOPOLOGY_METHOD=hwloc needs to be used. If hwloc is not supported/available, allocation will fallback to default path.
jpeyton52
reviewed
Apr 1, 2025
jpeyton52
reviewed
Apr 1, 2025
jpeyton52
left a comment
jpeyton52
left a comment
There was a problem hiding this comment.
Sorry about this, it appears that the memory attributes were added in HWLOC 2.3, but there was some mishap with the hwloc_location enum (there is a reference to HWLOC_LOCATION_TYPE_CPUSET in the __kmp_hwloc_alloc_membind() function. To get it working with all the 2.x versions of HWLOC, I had to add this little bit right under the #includes at the top of the file:
+#if KMP_USE_HWLOC
+#if HWLOC_API_VERSION > 0x00020300
+#define KMP_HWLOC_LOCATION_TYPE_CPUSET HWLOC_LOCATION_TYPE_CPUSET
+#elif HWLOC_API_VERSION == 0x00020300
+#define KMP_HWLOC_LOCATION_TYPE_CPUSET hwloc_location::HWLOC_LOCATION_TYPE_CPUSET
+#else
+enum hwloc_memattr_id_e {
+ HWLOC_MEMATTR_ID_BANDWIDTH,
+ HWLOC_MEMATTR_ID_CAPACITY
+};
+#endif
+#endif
Then we can change the HWLOC_API_VERSION to 0x00020400 to 0x00020300
jpeyton52
reviewed
Apr 1, 2025
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Apr 2, 2025
This reverts commit 730e8a4.
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Apr 3, 2025
This patch adds support for memory allocation using hwloc. To enable memory allocation using hwloc, env KMP_TOPOLOGY_METHOD=hwloc needs to be used. If hwloc is not supported/available, allocation will fallback to default path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for memory allocation using hwloc. To enable memory allocation using hwloc, env KMP_TOPOLOGY_METHOD=hwloc needs to be used. If hwloc is not supported/available, allocation will fallback to default path.