Skip to content

[clang] fix crash with ADL for member pointers with dependent class #132977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
+12 −2
Merged

[clang] fix crash with ADL for member pointers with dependent class #132977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/lib/Sema/SemaLookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3210,8 +3210,8 @@ addAssociatedClassesAndNamespaces(AssociatedLookup &Result, QualType Ty) {
// X.
case Type::MemberPointer: {
const MemberPointerType *MemberPtr = cast<MemberPointerType>(T);
addAssociatedClassesAndNamespaces(
Result, MemberPtr->getMostRecentCXXRecordDecl());
if (CXXRecordDecl *Class = MemberPtr->getMostRecentCXXRecordDecl())
addAssociatedClassesAndNamespaces(Result, Class);
T = MemberPtr->getPointeeType().getTypePtr();
continue;
}
Expand Down
10 changes: 10 additions & 0 deletions clang/test/SemaCXX/member-pointer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,3 +355,13 @@ namespace GH132401 {
};
template struct CallableHelper<void (QIODevice::*)()>;
} // namespace GH132401

namespace adl_dependent_class {
struct A {
template <class T> A(T);
};
struct C;
template <class T> void d(void (T::*)());
void f(A);
void g() { f(d<C>); }
} // namespace adl_dependent_class