Skip to content

[lldb] Adjust skips on reverse continue tests #133240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
+8 −12
Merged

[lldb] Adjust skips on reverse continue tests #133240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@

class TestReverseContinueBreakpoints(ReverseTestBase):
@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_reverse_continue(self):
self.reverse_continue_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_reverse_continue_async(self):
self.reverse_continue_internal(async_mode=True)

Expand Down Expand Up @@ -44,12 +42,10 @@ def reverse_continue_internal(self, async_mode):
self.assertEqual(process.GetExitStatus(), 0)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_reverse_continue_breakpoint(self):
self.reverse_continue_breakpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_reverse_continue_breakpoint_async(self):
self.reverse_continue_breakpoint_internal(async_mode=True)

Expand All @@ -67,12 +63,10 @@ def reverse_continue_breakpoint_internal(self, async_mode):
self.assertEqual(threads_now, initial_threads)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_reverse_continue_skip_breakpoint(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_reverse_continue_skip_breakpoint_async(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=True)

Expand All @@ -97,12 +91,10 @@ def reverse_continue_skip_breakpoint_internal(self, async_mode):
)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_continue_preserves_direction(self):
self.continue_preserves_direction_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
def test_continue_preserves_direction_asyhc(self):
self.continue_preserves_direction_internal(async_mode=True)

Expand Down
12 changes: 8 additions & 4 deletions lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@

class TestReverseContinueWatchpoints(ReverseTestBase):
@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
def test_reverse_continue_watchpoint(self):
self.reverse_continue_watchpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
def test_reverse_continue_watchpoint_async(self):
self.reverse_continue_watchpoint_internal(async_mode=True)

Expand Down Expand Up @@ -60,12 +62,14 @@ def reverse_continue_watchpoint_internal(self, async_mode):
)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
def test_reverse_continue_skip_watchpoint(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
# Watchpoints don't work in single-step mode
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
def test_reverse_continue_skip_watchpoint_async(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=True)

Expand Down