[lldb] Improve default statusline colors to work with more color schemes #133315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the reverse video [1] font effect (`${ansi.negative}`) as the
default for the statusline. Inverting the foreground and background
color has a better change as looking reasonably good, compared to
picking an arbitrary color.
[1] https://en.wikipedia.org/wiki/Reverse_video
Member
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesUse the reverse video [1] font effect ( [1] https://en.wikipedia.org/wiki/Reverse_video Full diff: https://github.com/llvm/llvm-project/pull/133315.diff 1 Files Affected:
diff --git a/lldb/source/Core/CoreProperties.td b/lldb/source/Core/CoreProperties.td
index 01a04f9e79095..af9eb139f0921 100644
--- a/lldb/source/Core/CoreProperties.td
+++ b/lldb/source/Core/CoreProperties.td
@@ -178,7 +178,7 @@ let Definition = "debugger" in {
Desc<"Whether to show a statusline at the bottom of the terminal.">;
def StatuslineFormat: Property<"statusline-format", "FormatEntity">,
Global,
- DefaultStringValue<"${ansi.bg.blue}${ansi.fg.black}{${target.file.basename}}{ | ${line.file.basename}:${line.number}:${line.column}}{ | ${thread.stop-reason}}{ | {${progress.count} }${progress.message}}">,
+ DefaultStringValue<"${ansi.negative}{${target.file.basename}}{ | ${line.file.basename}:${line.number}:${line.column}}{ | ${thread.stop-reason}}{ | {${progress.count} }${progress.message}}">,
Desc<"The default statusline format string.">;
def UseSourceCache: Property<"use-source-cache", "Boolean">,
Global,
|
adrian-prantl
approved these changes
Mar 27, 2025
Collaborator
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
As the person who suggested this change, I think this is a great idea :-)
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 29, 2025
…mes (llvm#133315) Use the reverse video [1] font effect (`${ansi.negative}`) as the default for the statusline. Inverting the foreground and background color has a better change as looking reasonably good, compared to picking an arbitrary color. [1] https://en.wikipedia.org/wiki/Reverse_video (cherry picked from commit c10e26b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the reverse video [1] font effect (
${ansi.negative}) as the default for the statusline. Inverting the foreground and background color has a better change as looking reasonably good, compared to picking an arbitrary color.[1] https://en.wikipedia.org/wiki/Reverse_video