Skip to content

Conversation

@googlewalt
Copy link
Contributor

This reverts commit 6c21716. It touches a common file as #133083, which is causing failures

This reverts commit 6c21716.
It touches a common file as llvm#133083, which is causing failures
@llvmbot
Copy link
Member

llvmbot commented Mar 27, 2025

@llvm/pr-subscribers-backend-x86

Author: Walter Lee (googlewalt)

Changes

This reverts commit 6c21716. It touches a common file as #133083, which is causing failures


Full diff: https://github.com/llvm/llvm-project/pull/133334.diff

1 Files Affected:

  • (modified) llvm/lib/Target/X86/X86ISelLowering.cpp (+1-1)
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index a514e7f1ab48c..81c75a2f98079 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -58959,7 +58959,7 @@ static SDValue combineINSERT_SUBVECTOR(SDNode *N, SelectionDAG &DAG,
   // If we're splatting the lower half subvector of a full vector load into the
   // upper half, attempt to create a subvector broadcast.
   // TODO: Drop hasOneUse checks.
-  if ((int)IdxVal == (VecNumElts / 2) &&
+  if (IdxVal == (VecNumElts / 2) &&
       Vec.getValueSizeInBits() == (2 * SubVec.getValueSizeInBits()) &&
       (Vec.hasOneUse() || SubVec.hasOneUse())) {
     auto *VecLd = dyn_cast<LoadSDNode>(Vec);

Copy link
Contributor

@Sterling-Augustine Sterling-Augustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of stacked changes needing to get to revert a change that breaks the build bots.

@googlewalt googlewalt merged commit e9dc051 into llvm:main Mar 27, 2025
7 of 11 checks passed
@googlewalt googlewalt deleted the rb branch October 22, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants