Skip to content

llvm-reduce: Use takeName instead of setName when cloning functions #133393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

llvm-reduce: Use takeName instead of setName when cloning functions #133393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,13 @@ static void extractArgumentsFromModule(Oracle &O, ReducerWorkItem &WorkItem) {

auto *ClonedFunc = CloneFunction(F, VMap);
// In order to preserve function order, we move Clone after old Function
ClonedFunc->takeName(F);
ClonedFunc->removeFromParent();
Program.getFunctionList().insertAfter(F->getIterator(), ClonedFunc);

replaceFunctionCalls(*F, *ClonedFunc, ArgIndexesToKeep);
// Rename Cloned Function to Old's name
std::string FName = std::string(F->getName());
F->replaceAllUsesWith(ClonedFunc);
F->eraseFromParent();
ClonedFunc->setName(FName);
}
}

Expand Down
4 changes: 1 addition & 3 deletions llvm/tools/llvm-reduce/deltas/ReduceOperandsToArgs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,9 @@ static void substituteOperandWithArgument(Function *OldF,
// Replace all OldF uses with NewF.
replaceFunctionCalls(OldF, NewF);

// Rename NewF to OldF's name.
std::string FName = OldF->getName().str();
NewF->takeName(OldF);
OldF->replaceAllUsesWith(NewF);
OldF->eraseFromParent();
NewF->setName(FName);
}

static void reduceOperandsToArgs(Oracle &O, ReducerWorkItem &WorkItem) {
Expand Down
Loading