Skip to content

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 28, 2025

Check if insert succeeded or not. This would change behavior
if there are recursive MDNodes, but I'm not sure those are a thing.

Check if insert succeeded or not. This would change behavior
if there are recursive MDNodes, but I'm not sure those are a thing.
Copy link
Contributor Author

arsenm commented Mar 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arsenm arsenm requested review from kazutakahirata and ormris March 28, 2025 14:17
@arsenm arsenm marked this pull request as ready for review March 28, 2025 14:17
@kazutakahirata
Copy link
Contributor

This would change behavior if there are recursive MDNodes, but I'm not sure those are a thing.

I haven't seen one, but I'm not sure either. That said, this is just llvm-reduce. The external interestingness test guarantees the interestingness, so the worse case is llvm-reduce producing a suboptimal result or crashing.

Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@arsenm arsenm merged commit 8dc64e9 into main Mar 28, 2025
15 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/avoid-double-map-lookup-reduce-di-metadata branch March 28, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants