Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

No description provided.

@kazutakahirata kazutakahirata requested a review from kuhar March 29, 2025 01:34
@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Mar 29, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 29, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/133552.diff

1 Files Affected:

  • (modified) mlir/tools/mlir-tblgen/RewriterGen.cpp (+1-1)
diff --git a/mlir/tools/mlir-tblgen/RewriterGen.cpp b/mlir/tools/mlir-tblgen/RewriterGen.cpp
index c8a12b9e21b90..68772e9a78a1c 100644
--- a/mlir/tools/mlir-tblgen/RewriterGen.cpp
+++ b/mlir/tools/mlir-tblgen/RewriterGen.cpp
@@ -1067,7 +1067,7 @@ void PatternEmitter::emit(StringRef rewriteName) {
   // Emit RewritePattern for Pattern.
   auto locs = pattern.getLocation();
   os << formatv("/* Generated from:\n    {0:$[ instantiating\n    ]}\n*/\n",
-                make_range(locs.rbegin(), locs.rend()));
+                llvm::reverse(locs));
   os << formatv(R"(struct {0} : public ::mlir::RewritePattern {
   {0}(::mlir::MLIRContext *context)
       : ::mlir::RewritePattern("{1}", {2}, context, {{)",

@kazutakahirata kazutakahirata merged commit 854d795 into llvm:main Mar 29, 2025
14 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_range_mlir branch March 29, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir:core MLIR Core Infrastructure mlir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants