Skip to content

[clang-tools-extra] Use *Set::insert_range (NFC) #133589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025
Merged

[clang-tools-extra] Use *Set::insert_range (NFC) #133589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,13 +333,10 @@ SignalHandlerCheck::SignalHandlerCheck(StringRef Name,
: ClangTidyCheck(Name, Context),
AsyncSafeFunctionSet(Options.get("AsyncSafeFunctionSet",
AsyncSafeFunctionSetKind::POSIX)) {
if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal) {
for (StringRef v : MinimalConformingFunctions)
ConformingFunctions.insert(v);
} else {
for (StringRef v : POSIXConformingFunctions)
ConformingFunctions.insert(v);
}
if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal)
ConformingFunctions.insert_range(MinimalConformingFunctions);
else
ConformingFunctions.insert_range(POSIXConformingFunctions);
}

void SignalHandlerCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Expand Down
4 changes: 1 addition & 3 deletions clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,9 +343,7 @@ void InconsistentDeclarationParameterNameCheck::check(

void InconsistentDeclarationParameterNameCheck::markRedeclarationsAsVisited(
const FunctionDecl *OriginalDeclaration) {
for (const FunctionDecl *Redecl : OriginalDeclaration->redecls()) {
VisitedDeclarations.insert(Redecl);
}
VisitedDeclarations.insert_range(OriginalDeclaration->redecls());
}

} // namespace clang::tidy::readability
3 changes: 1 addition & 2 deletions clang-tools-extra/clangd/ConfigCompile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,7 @@ struct FragmentCompiler {
[Normalized(std::move(Normalized))](const Params &, Config &C) {
if (C.Diagnostics.SuppressAll)
return;
for (llvm::StringRef N : Normalized)
C.Diagnostics.Suppress.insert(N);
C.Diagnostics.Suppress.insert_range(Normalized);
});

if (F.UnusedIncludes) {
Expand Down
3 changes: 1 addition & 2 deletions clang-tools-extra/clangd/index/dex/Dex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ std::unique_ptr<Iterator> Dex::createFileProximityIterator(
Sources[Path] = SourceParams();
auto PathURI = URI::create(Path).toString();
const auto PathProximityURIs = generateProximityURIs(PathURI.c_str());
for (const auto &ProximityURI : PathProximityURIs)
ParentURIs.insert(ProximityURI);
ParentURIs.insert_range(PathProximityURIs);
}
// Use SymbolRelevanceSignals for symbol relevance evaluation: use defaults
// for all parameters except for Proximity Path distance signal.
Expand Down