[CI] Fix Monolithic Linux Build in Ubuntu 24.04 #133628
Conversation
This patch fixes the monolithic linux build in Ubuntu 24.04. Newer versions of debian/ubuntu pass a warning when installing packages at the system level using pip as it interferes with system package manager installed python packages. We do not use any, so we just ignore the warning (that is an error without passing the flag) by passing the --break-system-packages flag.
boomanaiden154
requested review from
DavidSpickett,
Endilll,
Keenuts,
lnihlen and
tstellar
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
I suppose the "proper" way to do this is install virtualenv from apt and install into an isolated environment, which would help if we ever did decide to install anything from apt.
Then again, we prefer to have the package names in requirements.txt so they are easier to find, so it's unlikely we would use apt for something.
We do not use any,
I would say "any system package manager installed python packages" just to be extra clear, in case we have to refer back to this commit message later.
Right. The intention behind this flag is to get people to do that. The recommendation doesn't make as much sense for containers that serve a single purpose though.
Yep.
Updated. |
This reverts commit 23fb048. This broke the new premerge system as it appears the pip installations within the CI image do not support this option. Buildkite was unaffected.
This reverts commit d72be15. Now that the container version got bumped, we need to reland this.
3 participants
This patch fixes the monolithic linux build in Ubuntu 24.04. Newer versions of debian/ubuntu pass a warning when installing packages at the system level using pip as it interferes with system package manager installed python packages. We do not use any system package manager installed python packages, so we just ignore the warning (that is an error without passing the flag) by passing the --break-system-packages flag.