[libc] Add -Wextra for libc tests #133643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vinay-deshmukh
commented
Mar 30, 2025
vinay-deshmukh
commented
- Relates to: [libc] re-enable warnings for tests #119281
|
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
vinay-deshmukh
force-pushed
the
vinay-issue-119281-wextra
branch
from
edaf208 to
a2cd02a
Compare
|
Any suggestions on how I can diagnose the I'm unable to do a full build on Macbook m1, overlay build did pass successfully FWIW |
|
Looks like LlvmLibcMemcmpTest.SizeSweep is generating an illegal instruction, somehow. Perhaps you can run the test under lldb, and it can give you a backtrace of where the exeception is coming from. Build a debug build. |
|
The overlay build when done in Debug mode is passing for me, so unable to reproduce this CI failure locally. The CI seems to be doing a full build which is not supported on Macbook m1. Is there a way to 'disable' the |
|
@nickdesaulniers @lntue Please review this PR when you get a chance! Thanks! |
1 similar comment
|
@nickdesaulniers @lntue Please review this PR when you get a chance! Thanks! |
vinay-deshmukh
force-pushed
the
vinay-issue-119281-wextra
branch
from
d768cb6 to
8defd89
Compare
vinay-deshmukh
force-pushed
the
vinay-issue-119281-wextra
branch
from
8defd89 to
38b927c
Compare
Unfortunately, I don't have a local gcc install available. I tried a local overlay build on commit 34accca with: and which passed. FWIW CI was building until I merged from |
saturn691
changed the title
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/71/builds/28863 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/179/builds/28273 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/28156 Here is the relevant piece of the build log for the reference |
saturn691
added a commit
that referenced
this pull request
Aug 12, 2025
This reverts commit e617dc8.
|
The pre-merge seems to have not caught all the errors, or maybe the pre-merge checks took place some time ago. I'm going to revert this. |
saturn691
added a commit
that referenced
this pull request
Aug 12, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/183/builds/17157 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/196/builds/11243 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.