Re-apply "[AMDGPU][CodeGenPrepare] Narrow 64 bit math to 32 bit if profitable" #133893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if prof…" This reverts commit 7f14b2a.
Shoreshen
deleted the
revert-133880-revert-130577-narrow-math-for-and-operand
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply #130577
The old application failed in address sanitizer due to
tryNarrowMathIfNoOverflowwas called afterI.eraseFromParent();inAMDGPUCodeGenPrepareImpl::visitBinaryOperator, it create a use after free failure.To fix this,
tryNarrowMathIfNoOverflowwill be called before and directly return iftryNarrowMathIfNoOverflowresult in true.