Skip to content

[mlir] Use dyn_cast instead of cast in MathToVCIX conversion #134047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CoTinker merged 2 commits into from
Apr 2, 2025
Merged

[mlir] Use dyn_cast instead of cast in MathToVCIX conversion #134047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef32d01
[mlir] Use `dyn_cast` instead of `cast`
CoTinker Apr 2, 2025
3a17f5c
add test
CoTinker Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mlir/test/Conversion/MathToVCIX/math-to-vcix.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,3 +191,14 @@ func.func @log_fixed(%a: vector<8 x f32>, %rvl: i64) -> vector<8 x f32> {
%res = math.log %a : vector<8 x f32>
return %res : vector<8 x f32>
}

// -----

// Ensure this case exit gracefully

// CHECK-LABEL: func.func @no_vector_type
// CHECK: math.cos
func.func @no_vector_type(%arg0: f32) -> f32 {
%0 = math.cos %arg0 : f32
return %0 : f32
}
2 changes: 1 addition & 1 deletion mlir/test/lib/Conversion/MathToVCIX/TestMathToVCIXConversion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace {
/// according to LLVM's encoding:
/// https://lists.llvm.org/pipermail/llvm-dev/2020-October/145850.html
static std::pair<unsigned, VectorType> legalizeVectorType(const Type &type) {
VectorType vt = cast<VectorType>(type);
VectorType vt = dyn_cast<VectorType>(type);
// To simplify test pass, avoid multi-dimensional vectors.
if (!vt || vt.getRank() != 1)
return {0, nullptr};
Expand Down
Loading