Skip to content

Conversation

@rjodinchr
Copy link
Contributor

clspv uses a better implementation that is not using a bigger side when not available.
Add a dummy implementation for mul_hi to avoid to override the implementation of clspv with the one in libclc.

clspv uses a better implementation that is not using a bigger side
when not available.
Add a dummy implementation for mul_hi to avoid to override the
implementation of clspv with the one in libclc.
@rjodinchr
Copy link
Contributor Author

@frasercrmck could you please review?

@rjodinchr
Copy link
Contributor Author

For the record, clspv implementation is based on OpMulExtended which is SPIR-V specific and not accessible from C.

Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me.

It's a shame we've got such an ugly way of "opting out" of builtins, but I don't know if it's worth coming up with a nicer one.

@rjodinchr
Copy link
Contributor Author

It's a shame we've got such an ugly way of "opting out" of builtins, but I don't know if it's worth coming up with a nicer one.

Yes, I don't think it's worth it right now.

Could you please submit that PR?

@frasercrmck
Copy link
Contributor

It's a shame we've got such an ugly way of "opting out" of builtins, but I don't know if it's worth coming up with a nicer one.

Yes, I don't think it's worth it right now.

Could you please submit that PR?

Sure thing.

One thing I wondered is whether the empty file could be given a comment about why it's intentionally left empty. What do you think?

@frasercrmck frasercrmck merged commit 7baa7ed into llvm:main Apr 3, 2025
11 checks passed
@rjodinchr rjodinchr deleted the pr/clspv-mul-hi branch April 3, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants