Skip to content

[libc++] Enable sized deallocation when building operator new shims on Apple #134152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

[libc++] Enable sized deallocation when building operator new shims on Apple #134152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libcxx/utils/ci/apple-install-libcxx.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ for arch in ${architectures}; do
step "Building shims to make libc++ compatible with the system libc++ on Apple platforms when running the tests"
shims_library="${build_dir}/${arch}/apple-system-shims.a"
# Note that this doesn't need to match the Standard version used to build the rest of the library.
xcrun clang++ -c -std=c++2b -target ${target} "${llvm_root}/libcxxabi/src/vendor/apple/shims.cpp" -static -o "${shims_library}"
# Also note that we explicitly enable sized deallocation when building the shims to ensure that we provide as
# many symbols as possible.
xcrun clang++ -c -std=c++2b -fsized-deallocation -target ${target} "${llvm_root}/libcxxabi/src/vendor/apple/shims.cpp" -static -o "${shims_library}"
step "Building libc++.dylib and libc++abi.dylib for architecture ${arch}"
xcrun cmake -S "${llvm_root}/runtimes" \
Expand Down
Loading